customtabs: Intialize renderer at WebContents creation time.

customtabs: Intialize renderer at WebContents creation time.

The WebContents created in CustomTabActivity.java will certainly
navigate to a page and need a renderer, so there's no reason to delay
renderer initialization. Instead of calling
WebContentsFactory.createWebContents, we call
WebContentsFactory.createWebContentsWithWarmRenderer, which initiates
render initialization immediately.

BUG=695807
Review-Url: https://codereview.chromium.org/2714073003
Cr-Commit-Position: refs/heads/master@{#453200}
Committed: https://chromium.googlesource.com/chromium/src/+/60c2e708f18b501cfbea9a3d9a5a8ef8a5a3d9e4

[trevordixon, 2017-02-24 15:10:58]

trevordixon@chromium.org changed reviewers:
+ lizeb@chromium.org

[Benoit L, 2017-02-24 15:22:15]

On 2017/02/24 15:11:36, trevordixon wrote:

Thanks.

about the commit message: in Chromium, sticking to a short first line is
preferred, as well as adding a tag.

In this case,
customtabs: Intialize the WebContents at creation time.


Or something similar would do.

[trevordixon, 2017-02-24 16:51:20]

On 2017/02/24 at 15:22:15, lizeb wrote:
> On 2017/02/24 15:11:36, trevordixon wrote:
> 
> Thanks.
> 
> about the commit message: in Chromium, sticking to a short first line is
preferred, as well as adding a tag.
> 
> In this case,
> customtabs: Intialize the WebContents at creation time.
> 
> 
> Or something similar would do.

Changed. Thanks.

[Benoit L, 2017-02-24 17:00:33]

On 2017/02/24 16:51:20, trevordixon wrote:
> On 2017/02/24 at 15:22:15, lizeb wrote:
> > On 2017/02/24 15:11:36, trevordixon wrote:
> > 
> > Thanks.
> > 
> > about the commit message: in Chromium, sticking to a short first line is
> preferred, as well as adding a tag.
> > 
> > In this case,
> > customtabs: Intialize the WebContents at creation time.
> > 
> > 
> > Or something similar would do.
> 
> Changed. Thanks.

Oops, forgot to mention that the way to change it is to use git cl description,
or the web interface.

After that, LGTM

[trevordixon, 2017-02-27 12:49:22]

Description was changed from

==========
When creating WebContents for Custom Tabs, initiate renderer
initialization sooner.

The WebContents created in CustomTabActivity.java will certainly
navigate to a page and need a renderer, so there's no reason to delay
renderer initialization. Instead of calling
WebContentsFactory.createWebContents, we call
WebContentsFactory.createWebContentsWithWarmRenderer, which initiates
render initialization immediately.

BUG=695807
==========

to

==========
customtabs: Intialize renderer at WebContents creation time.

The WebContents created in CustomTabActivity.java will certainly
navigate to a page and need a renderer, so there's no reason to delay
renderer initialization. Instead of calling
WebContentsFactory.createWebContents, we call
WebContentsFactory.createWebContentsWithWarmRenderer, which initiates
render initialization immediately.

BUG=695807
==========

[trevordixon, 2017-02-27 12:50:10]

On 2017/02/24 at 17:00:33, lizeb wrote:
> On 2017/02/24 16:51:20, trevordixon wrote:
> > On 2017/02/24 at 15:22:15, lizeb wrote:
> > > On 2017/02/24 15:11:36, trevordixon wrote:
> > > 
> > > Thanks.
> > > 
> > > about the commit message: in Chromium, sticking to a short first line is
> > preferred, as well as adding a tag.
> > > 
> > > In this case,
> > > customtabs: Intialize the WebContents at creation time.
> > > 
> > > 
> > > Or something similar would do.
> > 
> > Changed. Thanks.
> 
> Oops, forgot to mention that the way to change it is to use git cl
description, or the web interface.
> 
> After that, LGTM

Ah, I only changed the issue title, not the first line. Now it's changed.

[trevordixon, 2017-02-27 12:50:18]

The CQ bit was checked by trevordixon@chromium.org

[commit-bot: I haz the power, 2017-02-27 12:50:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 13:27:00]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488199818742430, "parent_rev":
"fbb7fb60fb7ceaf4f737c638bbd502d26fe129b3", "commit_rev":
"60c2e708f18b501cfbea9a3d9a5a8ef8a5a3d9e4"}

[commit-bot: I haz the power, 2017-02-27 13:27:39]

Description was changed from

==========
customtabs: Intialize renderer at WebContents creation time.

The WebContents created in CustomTabActivity.java will certainly
navigate to a page and need a renderer, so there's no reason to delay
renderer initialization. Instead of calling
WebContentsFactory.createWebContents, we call
WebContentsFactory.createWebContentsWithWarmRenderer, which initiates
render initialization immediately.

BUG=695807
==========

to

==========
customtabs: Intialize renderer at WebContents creation time.

The WebContents created in CustomTabActivity.java will certainly
navigate to a page and need a renderer, so there's no reason to delay
renderer initialization. Instead of calling
WebContentsFactory.createWebContents, we call
WebContentsFactory.createWebContentsWithWarmRenderer, which initiates
render initialization immediately.

BUG=695807

Review-Url: https://codereview.chromium.org/2714073003
Cr-Commit-Position: refs/heads/master@{#453200}
Committed:
https://chromium.googlesource.com/chromium/src/+/60c2e708f18b501cfbea9a3d9a5a...
==========

[commit-bot: I haz the power, 2017-02-27 13:27:40]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/60c2e708f18b501cfbea9a3d9a5a...