views: don't try to SetProperty on NSWindows

chrome/browser/ui/views/frame/browser_window_factory.cc

Index: chrome/browser/ui/views/frame/browser_window_factory.cc
diff --git a/chrome/browser/ui/views/frame/browser_window_factory.cc b/chrome/browser/ui/views/frame/browser_window_factory.cc
index f8b524f088e5977a47f7ed84a39a9a552fed907f..7fafcdee9c2030ed4381ad3751d26a7e7b696fb4 100644
--- a/chrome/browser/ui/views/frame/browser_window_factory.cc
+++ b/chrome/browser/ui/views/frame/browser_window_factory.cc
@@ -21,8 +21,12 @@ BrowserWindow* BrowserWindow::CreateBrowserWindow(Browser* browser,
   (new BrowserFrame(view))->InitBrowserFrame();
   view->GetWidget()->non_client_view()->SetAccessibleName(
       l10n_util::GetStringUTF16(IDS_PRODUCT_NAME));
-  // For now, all browser windows are true.
+
+#if defined(USE_AURA)
+  // For now, all browser windows are true. This only works when USE_AURA
+  // because it requires gfx::NativeWindow to be an aura::Window*.
   view->GetWidget()->GetNativeWindow()->SetProperty(

[sky, 2017/02/24 18:35:16]

An alternative is to call view->GetWidget()->SetNativeProperty(). That said, I
think the user gesture isn't needed on mac, so I'm ok with this fix. That said,
please put the aura includes in an ifdef aura as well.

       aura::client::kCreatedByUserGesture, user_gesture);
+#endif
   return view;
 }