chrome/browser/ui/views/webshare/webshare_target_picker_view_unittest.cc - Issue 2714053003: Fix GCC build for target 'all'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/webshare/webshare_target_picker_view_unittest.cc

Issue 2714053003: Fix GCC build for target 'all' (Closed)

Patch Set: Remove auto Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/libgtkui/gtk_ui.cc ('K') | « chrome/browser/ui/views/webshare/webshare_target_picker_view.h ('k') | components/certificate_transparency/ct_policy_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/webshare/webshare_target_picker_view_unittest.cc

diff --git a/chrome/browser/ui/views/webshare/webshare_target_picker_view_unittest.cc b/chrome/browser/ui/views/webshare/webshare_target_picker_view_unittest.cc

index a8d0478933ce2529cd5b6aacee956db940d20856..ea49271b8a1cb6769c33e2a774fc0993187060a9 100644

--- a/chrome/browser/ui/views/webshare/webshare_target_picker_view_unittest.cc

+++ b/chrome/browser/ui/views/webshare/webshare_target_picker_view_unittest.cc

@@ -24,7 +24,7 @@

#include "ui/views/window/dialog_delegate.h"

#include "url/gurl.h"

-namespace {

+namespace test {

Lei Zhang 2017/02/25 00:50:34 Just remove the namespace?

Tom (Use chromium acct) 2017/02/25 01:40:21 Done.

class WebShareTargetPickerViewTest : public views::ViewsTestBase {

public:

@@ -170,4 +170,4 @@ TEST_F(WebShareTargetPickerViewTest, ChooseItemWithDoubleClick) {

result());

}

-} // namespace

+} // namespace test