Description was changed from ========== Fix GCC build ========== to ========== Fix GCC build CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ...
3 years, 10 months ago
(2017-02-24 23:07:01 UTC)
#1
Description was changed from
==========
Fix GCC build
==========
to
==========
Fix GCC build
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========
Tom (Use chromium acct)
Description was changed from ========== Fix GCC build CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Fix GCC build ...
3 years, 10 months ago
(2017-02-24 23:07:01 UTC)
#2
Description was changed from
==========
Fix GCC build
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========
to
==========
Fix GCC build
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========
Tom (Use chromium acct)
Description was changed from ========== Fix GCC build CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Fix GCC build ...
3 years, 10 months ago
(2017-02-24 23:12:48 UTC)
#3
Description was changed from
==========
Fix GCC build
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========
to
==========
Fix GCC build
This CL fixes the build when compiling with GCC 4.8 (the highest version
that ships with trusty). There are also some build errors in third_party
which will be fixed with separate CLs.
gn args:
is_debug = false
is_clang = false
use_sysroot = false
proprietary_codecs = true
ffmpeg_branding = "Chrome"
is_component_build = true
enable_nacl = false
use_goma = true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========
Tom (Use chromium acct)
Description was changed from ========== Fix GCC build This CL fixes the build when compiling ...
3 years, 10 months ago
(2017-02-24 23:14:17 UTC)
#4
Description was changed from
==========
Fix GCC build
This CL fixes the build when compiling with GCC 4.8 (the highest version
that ships with trusty). There are also some build errors in third_party
which will be fixed with separate CLs.
gn args:
is_debug = false
is_clang = false
use_sysroot = false
proprietary_codecs = true
ffmpeg_branding = "Chrome"
is_component_build = true
enable_nacl = false
use_goma = true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========
to
==========
Fix GCC build for target 'all'
This CL fixes the build when compiling with GCC 4.8 (the highest version
that ships with trusty). There are also some build errors in third_party
which will be fixed with separate CLs.
gn args:
is_debug = false
is_clang = false
use_sysroot = false
proprietary_codecs = true
ffmpeg_branding = "Chrome"
is_component_build = true
enable_nacl = false
use_goma = true
R=jam@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/397732)
3 years, 10 months ago
(2017-02-24 23:48:11 UTC)
#12
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/218498) android_n5x_swarming_rel on ...
3 years, 10 months ago
(2017-02-25 00:31:06 UTC)
#16
3 years, 10 months ago
(2017-02-25 00:34:51 UTC)
#17
https://codereview.chromium.org/2714053003/diff/20001/components/certificate_...
File components/certificate_transparency/ct_policy_manager_unittest.cc (right):
https://codereview.chromium.org/2714053003/diff/20001/components/certificate_...
components/certificate_transparency/ct_policy_manager_unittest.cc:23:
base::ListValue* ListValueFromStrings(const std::vector<const char*>& strings) {
On 2017/02/24 23:32:00, Ryan Sleevi (overloaded) wrote:
> NON-BLOCKING: Could you explain why this change is necessary/what this warning
> was about?
>
> The desire was to avoid a vector coercion, but I'm curious why it's being
forced
> here, and would love to avoid it and/or understand it.
With the original file, I was getting errors like this:
../../components/certificate_transparency/ct_policy_manager_unittest.cc: In
member function 'virtual void
certificate_transparency::{anonymous}::CTPolicyManagerTest_DelegateChecksRequired_Test::TestBody()':
../../components/certificate_transparency/ct_policy_manager_unittest.cc:71:67:
error: no matching function for call to 'ListValueFromStrings(<brace-enclosed
initializer list>)'
ListValueFromStrings({"google.com"}));
^
../../components/certificate_transparency/ct_policy_manager_unittest.cc:71:67:
note: candidate is:
../../components/certificate_transparency/ct_policy_manager_unittest.cc:24:18:
note: template<long unsigned int N> base::ListValue*
certificate_transparency::{anonymous}::ListValueFromStrings(const char* const
(&)[N])
base::ListValue* ListValueFromStrings(const char* const (&strings)[N]) {
^
../../components/certificate_transparency/ct_policy_manager_unittest.cc:24:18:
note: template argument deduction/substitution failed:
../../components/certificate_transparency/ct_policy_manager_unittest.cc:71:67:
note: couldn't deduce template parameter 'N'
ListValueFromStrings({"google.com"}));
^
../../components/certificate_transparency/ct_policy_manager_unittest.cc: In
member function 'virtual void
certificate_transparency::{anonymous}::CTPolicyManagerTest_DelegateChecksExcluded_Test::TestBody()':
../../components/certificate_transparency/ct_policy_manager_unittest.cc:98:67:
error: no matching function for call to 'ListValueFromStrings(<brace-enclosed
initializer list>)'
ListValueFromStrings({"google.com"}));
Ryan Sleevi
https://codereview.chromium.org/2714053003/diff/20001/components/certificate_transparency/ct_policy_manager_unittest.cc File components/certificate_transparency/ct_policy_manager_unittest.cc (right): https://codereview.chromium.org/2714053003/diff/20001/components/certificate_transparency/ct_policy_manager_unittest.cc#newcode23 components/certificate_transparency/ct_policy_manager_unittest.cc:23: base::ListValue* ListValueFromStrings(const std::vector<const char*>& strings) { Oh, I just ...
3 years, 10 months ago
(2017-02-25 00:49:15 UTC)
#18
https://codereview.chromium.org/2714053003/diff/20001/components/certificate_...
File components/certificate_transparency/ct_policy_manager_unittest.cc (right):
https://codereview.chromium.org/2714053003/diff/20001/components/certificate_...
components/certificate_transparency/ct_policy_manager_unittest.cc:23:
base::ListValue* ListValueFromStrings(const std::vector<const char*>& strings) {
Oh, I just realized why - these should have been [ ] initialized rather than { }
initialized.
At the risk of being a pain for what is arguably 'not your fault', would you be
open to using that form of the change instead?
e.g.
ListValueFromStrings(["google.com"]);
ListValueFromStrings(["example.com", ".sub.example.com",
".sub.accounts.example.com"]);
?
(If it's too much of a pain/unreasonable, I can always take it as a cleanup
item)
3 years, 10 months ago
(2017-02-25 01:40:21 UTC)
#21
https://codereview.chromium.org/2714053003/diff/20001/components/certificate_...
File components/certificate_transparency/ct_policy_manager_unittest.cc (right):
https://codereview.chromium.org/2714053003/diff/20001/components/certificate_...
components/certificate_transparency/ct_policy_manager_unittest.cc:23:
base::ListValue* ListValueFromStrings(const std::vector<const char*>& strings) {
On 2017/02/25 00:49:15, Ryan Sleevi (overloaded) wrote:
> Oh, I just realized why - these should have been [ ] initialized rather than {
}
> initialized.
>
> At the risk of being a pain for what is arguably 'not your fault', would you
be
> open to using that form of the change instead?
>
> e.g.
>
> ListValueFromStrings(["google.com"]);
> ListValueFromStrings(["example.com", ".sub.example.com",
> ".sub.accounts.example.com"]);
>
> ?
>
> (If it's too much of a pain/unreasonable, I can always take it as a cleanup
> item)
That still doesn't work
../../components/certificate_transparency/ct_policy_manager_unittest.cc: In
member function 'virtual void
certificate_transparency::{anonymous}::CTPolicyManagerTest_DelegateChecksRequired_Test::TestBody()':
../../components/certificate_transparency/ct_policy_manager_unittest.cc:71:54:
error: expected identifier before string constant
ListValueFromStrings(["google.com"]));
^
https://codereview.chromium.org/2714053003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
(right):
https://codereview.chromium.org/2714053003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc:132:
return std::unique_ptr<content::ResourceThrottle>(throttle.release());
On 2017/02/25 00:50:34, Lei Zhang (super slow) wrote:
> I think you can do: return std::move(throttle);
Done.
https://codereview.chromium.org/2714053003/diff/40001/chrome/browser/ui/libgt...
File chrome/browser/ui/libgtkui/gtk_ui.cc (right):
https://codereview.chromium.org/2714053003/diff/40001/chrome/browser/ui/libgt...
chrome/browser/ui/libgtkui/gtk_ui.cc:713: return
std::unique_ptr<views::Border>(gtk_border.release());
On 2017/02/25 00:50:34, Lei Zhang (super slow) wrote:
> std::move again.
Done.
https://codereview.chromium.org/2714053003/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/webshare/webshare_target_picker_view_unittest.cc
(right):
https://codereview.chromium.org/2714053003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/webshare/webshare_target_picker_view_unittest.cc:27:
namespace test {
On 2017/02/25 00:50:34, Lei Zhang (super slow) wrote:
> Just remove the namespace?
Done.
Tom (Use chromium acct)
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
3 years, 10 months ago
(2017-02-25 01:40:27 UTC)
#22
Description was changed from ========== Fix GCC build for target 'all' This CL fixes the ...
3 years, 10 months ago
(2017-02-25 01:51:01 UTC)
#25
Description was changed from
==========
Fix GCC build for target 'all'
This CL fixes the build when compiling with GCC 4.8 (the highest version
that ships with trusty). There are also some build errors in third_party
which will be fixed with separate CLs.
gn args:
is_debug = false
is_clang = false
use_sysroot = false
proprietary_codecs = true
ffmpeg_branding = "Chrome"
is_component_build = true
enable_nacl = false
use_goma = true
R=jam@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========
to
==========
Fix GCC build for target 'all'
This CL fixes the build when compiling with GCC 4.8 (the highest version
that ships with trusty).
Required third_party changes:
https://swiftshader-review.googlesource.com/#/c/8888/https://chromium-review.googlesource.com/c/446938/https://chromium-review.googlesource.com/c/446866/
gn args:
is_debug = false
is_clang = false
use_sysroot = false
proprietary_codecs = true
ffmpeg_branding = "Chrome"
is_component_build = true
enable_nacl = false
use_goma = true
R=jam@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago
(2017-02-25 01:58:02 UTC)
#26
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/318307)
3 years, 10 months ago
(2017-02-25 01:58:03 UTC)
#27
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/356124)
3 years, 10 months ago
(2017-02-25 02:29:04 UTC)
#31
Issue 2714053003: Fix GCC build for target 'all'
(Closed)
Created 3 years, 10 months ago by Tom (Use chromium acct)
Modified 3 years, 9 months ago
Reviewers: jam, Ryan Sleevi, Lei Zhang
Base URL:
Comments: 11