Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 2714053003: Fix GCC build for target 'all' (Closed)

Created:
3 years, 10 months ago by Tom (Use chromium acct)
Modified:
3 years, 9 months ago
Reviewers:
Lei Zhang, jam, Ryan Sleevi
CC:
chromium-reviews, rsleevi+watch_chromium.org, certificate-transparency-chrome_googlegroups.com, dominickn+watch_chromium.org, Eran Messeri, chromoting-reviews_chromium.org, dshwang, bnc+watch_chromium.org, apacible+watch_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, net-reviews_chromium.org, blink-reviews-paint_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, xjz+watch_chromium.org, subresource-filter-reviews_chromium.org, imcheng+watch_chromium.org, jasonroberts+watch_google.com, feature-media-reviews_chromium.org, fuzzing_chromium.org, piman+watch_chromium.org, zpeng+watch_chromium.org, tfarina, avayvod+watch_chromium.org, pkotwicz+watch_chromium.org, martijn+crwatch_martijnc.be, isheriff+watch_chromium.org, erickung+watch_chromium.org, Lei Zhang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GCC build for target 'all' This CL fixes the build when compiling with GCC 4.8 (the highest version that ships with trusty). Required third_party changes: https://swiftshader-review.googlesource.com/#/c/8888/ https://chromium-review.googlesource.com/c/446938/ https://chromium-review.googlesource.com/c/446866/ gn args: is_debug = false is_clang = false use_sysroot = false proprietary_codecs = true ffmpeg_branding = "Chrome" is_component_build = true enable_nacl = false use_goma = true R=jam@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2714053003 Cr-Commit-Position: refs/heads/master@{#453476} Committed: https://chromium.googlesource.com/chromium/src/+/b95cf280873664a44297368676ff589721ddb6f2

Patch Set 1 #

Patch Set 2 : . #

Total comments: 5

Patch Set 3 : Remove auto #

Total comments: 6

Patch Set 4 : Address thestig@'s comments #

Patch Set 5 : const auto& -> auto* const #

Patch Set 6 : #if defined(__GNUC__) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -91 lines) Patch
M chrome/browser/banners/app_banner_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/cast_remoting_connector_fuzzertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/previews/previews_service.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/subresource_filter/subresource_filter_browsertest.cc View 5 chunks +13 lines, -10 lines 0 comments Download
M chrome/browser/ui/libgtkui/gtk_ui.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/test/test_browser_dialog.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/webshare/webshare_target_picker_view.h View 1 2 3 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/ui/views/webshare/webshare_target_picker_view_unittest.cc View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download
M components/certificate_transparency/ct_policy_manager_unittest.cc View 1 2 3 4 7 chunks +20 lines, -16 lines 0 comments Download
M components/dom_distiller/standalone/content_extractor_browsertest.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M gpu/tools/compositor_model_bench/render_tree.cc View 1 2 3 5 chunks +4 lines, -5 lines 0 comments Download
M net/http2/hpack/decoder/hpack_block_decoder_test.cc View 5 chunks +16 lines, -16 lines 0 comments Download
M net/quic/core/congestion_control/windowed_filter.h View 1 2 3 4 5 1 chunk +7 lines, -0 lines 0 comments Download
M remoting/host/security_key/fake_security_key_ipc_server.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M testing/libfuzzer/tests/fuzzer_launcher_test.cc View 8 chunks +16 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/page/NetworkStateNotifier.h View 2 chunks +9 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/examples_window.h View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/view_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 40 (28 generated)
Tom (Use chromium acct)
jam ptal
3 years, 10 months ago (2017-02-24 23:16:42 UTC) #6
Ryan Sleevi
https://codereview.chromium.org/2714053003/diff/20001/components/certificate_transparency/ct_policy_manager_unittest.cc File components/certificate_transparency/ct_policy_manager_unittest.cc (right): https://codereview.chromium.org/2714053003/diff/20001/components/certificate_transparency/ct_policy_manager_unittest.cc#newcode23 components/certificate_transparency/ct_policy_manager_unittest.cc:23: base::ListValue* ListValueFromStrings(const std::vector<const char*>& strings) { NON-BLOCKING: Could you ...
3 years, 10 months ago (2017-02-24 23:32:00 UTC) #10
Tom (Use chromium acct)
https://codereview.chromium.org/2714053003/diff/20001/components/certificate_transparency/ct_policy_manager_unittest.cc File components/certificate_transparency/ct_policy_manager_unittest.cc (right): https://codereview.chromium.org/2714053003/diff/20001/components/certificate_transparency/ct_policy_manager_unittest.cc#newcode23 components/certificate_transparency/ct_policy_manager_unittest.cc:23: base::ListValue* ListValueFromStrings(const std::vector<const char*>& strings) { On 2017/02/24 23:32:00, ...
3 years, 10 months ago (2017-02-25 00:34:51 UTC) #17
Ryan Sleevi
https://codereview.chromium.org/2714053003/diff/20001/components/certificate_transparency/ct_policy_manager_unittest.cc File components/certificate_transparency/ct_policy_manager_unittest.cc (right): https://codereview.chromium.org/2714053003/diff/20001/components/certificate_transparency/ct_policy_manager_unittest.cc#newcode23 components/certificate_transparency/ct_policy_manager_unittest.cc:23: base::ListValue* ListValueFromStrings(const std::vector<const char*>& strings) { Oh, I just ...
3 years, 10 months ago (2017-02-25 00:49:15 UTC) #18
Lei Zhang
chrome/ is about half of this CL. Split it off into another CL and I ...
3 years, 10 months ago (2017-02-25 00:50:34 UTC) #20
Tom (Use chromium acct)
https://codereview.chromium.org/2714053003/diff/20001/components/certificate_transparency/ct_policy_manager_unittest.cc File components/certificate_transparency/ct_policy_manager_unittest.cc (right): https://codereview.chromium.org/2714053003/diff/20001/components/certificate_transparency/ct_policy_manager_unittest.cc#newcode23 components/certificate_transparency/ct_policy_manager_unittest.cc:23: base::ListValue* ListValueFromStrings(const std::vector<const char*>& strings) { On 2017/02/25 00:49:15, ...
3 years, 10 months ago (2017-02-25 01:40:21 UTC) #21
Ryan Sleevi
https://codereview.chromium.org/2714053003/diff/20001/components/certificate_transparency/ct_policy_manager_unittest.cc File components/certificate_transparency/ct_policy_manager_unittest.cc (right): https://codereview.chromium.org/2714053003/diff/20001/components/certificate_transparency/ct_policy_manager_unittest.cc#newcode23 components/certificate_transparency/ct_policy_manager_unittest.cc:23: base::ListValue* ListValueFromStrings(const std::vector<const char*>& strings) { On 2017/02/25 01:40:21, ...
3 years, 10 months ago (2017-02-25 01:42:42 UTC) #24
jam
lgtm
3 years, 9 months ago (2017-02-27 16:18:30 UTC) #32
jam
btw for multiple cls that fix one issue (i.e. building with gcc 4.8), it's nice ...
3 years, 9 months ago (2017-02-27 16:19:13 UTC) #33
Lei Zhang
chrome/ lgtm
3 years, 9 months ago (2017-02-27 19:44:37 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2714053003/100001
3 years, 9 months ago (2017-02-28 00:59:11 UTC) #37
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 02:49:28 UTC) #40
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/b95cf280873664a44297368676ff...

Powered by Google App Engine
This is Rietveld 408576698