chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc - Issue 2714053003: Fix GCC build for target 'all'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

Issue 2714053003: Fix GCC build for target 'all' (Closed)

Patch Set: Remove auto Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/banners/app_banner_manager_browsertest.cc ('k') | chrome/browser/media/cast_remoting_connector_fuzzertest.cc » ('j') | chrome/browser/ui/libgtkui/gtk_ui.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc b/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

index aaa3df605dcc49e5254961c7a814666121f6c343..a60c59a2a8d2df912ecd00e9bbcbcae6eb4dbf4a 100644

--- a/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

+++ b/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

@@ -129,7 +129,7 @@ class TestNavigationListener

auto throttle = base::MakeUnique<Throttle>();

throttle->set_url(url);

throttles_.push_back(throttle->AsWeakPtr());

- return throttle;

+ return std::unique_ptr<content::ResourceThrottle>(throttle.release());

Lei Zhang 2017/02/25 00:50:34 I think you can do: return std::move(throttle);

Tom (Use chromium acct) 2017/02/25 01:40:21 Done.

}

private: