Extension Docs: Document asyncBlocking in the Web Request API Docs.

Extension Docs: Document asyncBlocking in the Web Request API Docs.

BUG=695607
Review-Url: https://codereview.chromium.org/2714023002
Cr-Commit-Position: refs/heads/master@{#452755}
Committed: https://chromium.googlesource.com/chromium/src/+/805486b4386ec845de6098bb9ff58521089d51eb

[karandeepb, 2017-02-23 22:44:09]

Description was changed from

==========
Extension Docs: Document asyncBlocking in the Web Request API Docs.
==========

to

==========
Extension Docs: Document asyncBlocking in the Web Request API Docs.

BUG=695607
==========

[karandeepb, 2017-02-23 22:56:14]

karandeepb@chromium.org changed reviewers:
+ lazyboy@chromium.org

[karandeepb, 2017-02-23 22:56:14]

PTAL Istiaque.

[lazyboy, 2017-02-24 00:17:22]

https://codereview.chromium.org/2714023002/diff/1/chrome/common/extensions/do...
File chrome/common/extensions/docs/templates/intros/webRequest.html (right):

https://codereview.chromium.org/2714023002/diff/1/chrome/common/extensions/do...
chrome/common/extensions/docs/templates/intros/webRequest.html:215:
<code>onAuthRequired</code>), the extension can generate the
<code>onAuthRequired</code> event), ...
nit: change to "the extension can generate $(ref:..BlockingResponse)
asynchronously"
(i.e. no "object").
Remove everything else after ", unlike the ..." because we've already covered
that above, right?

https://codereview.chromium.org/2714023002/diff/1/extensions/common/api/web_r...
File extensions/common/api/web_request.json (right):

https://codereview.chromium.org/2714023002/diff/1/extensions/common/api/web_r...
extensions/common/api/web_request.json:365: "description": "Fired when an
authentication failure is received. The listener has three options: it can
provide authentication credentials, it can cancel the request and display the
error page, or it can take no action on the challenge. If bad user credentials
are provided, this may be called multiple times for the same request. Note, only
one of <code>'blocking'</code> or <code>'asyncBlocking'</code> modes must be
specified.",
.. modes can be specified in <code>extraInfoSpec</code> parameter.

https://codereview.chromium.org/2714023002/diff/1/extensions/common/api/web_r...
extensions/common/api/web_request.json:392: "name": "async_callback",
nit: asyncCallback

[karandeepb, 2017-02-24 01:04:08]

Patchset #2 (id:20001) has been deleted

[karandeepb, 2017-02-24 01:04:40]

PTAL Istiaque.

https://codereview.chromium.org/2714023002/diff/1/chrome/common/extensions/do...
File chrome/common/extensions/docs/templates/intros/webRequest.html (right):

https://codereview.chromium.org/2714023002/diff/1/chrome/common/extensions/do...
chrome/common/extensions/docs/templates/intros/webRequest.html:215:
<code>onAuthRequired</code>), the extension can generate the
On 2017/02/24 00:17:22, lazyboy wrote:
> <code>onAuthRequired</code> event), ...
> nit: change to "the extension can generate $(ref:..BlockingResponse)
> asynchronously"
> (i.e. no "object").
> Remove everything else after ", unlike the ..." because we've already covered
> that above, right?

Done.

https://codereview.chromium.org/2714023002/diff/1/extensions/common/api/web_r...
File extensions/common/api/web_request.json (right):

https://codereview.chromium.org/2714023002/diff/1/extensions/common/api/web_r...
extensions/common/api/web_request.json:365: "description": "Fired when an
authentication failure is received. The listener has three options: it can
provide authentication credentials, it can cancel the request and display the
error page, or it can take no action on the challenge. If bad user credentials
are provided, this may be called multiple times for the same request. Note, only
one of <code>'blocking'</code> or <code>'asyncBlocking'</code> modes must be
specified.",
On 2017/02/24 00:17:22, lazyboy wrote:
> .. modes can be specified in <code>extraInfoSpec</code> parameter.

Done.

https://codereview.chromium.org/2714023002/diff/1/extensions/common/api/web_r...
extensions/common/api/web_request.json:392: "name": "async_callback",
On 2017/02/24 00:17:22, lazyboy wrote:
> nit: asyncCallback

Done.

[lazyboy, 2017-02-24 01:39:26]

lgtm

[karandeepb, 2017-02-24 04:10:50]

The CQ bit was checked by karandeepb@chromium.org

[commit-bot: I haz the power, 2017-02-24 04:11:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 05:11:04]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487909450255350,
"parent_rev": "0daf4efa277779e84a3d8c2091b6f8cac67b8724", "commit_rev":
"805486b4386ec845de6098bb9ff58521089d51eb"}

[commit-bot: I haz the power, 2017-02-24 05:12:33]

Description was changed from

==========
Extension Docs: Document asyncBlocking in the Web Request API Docs.

BUG=695607
==========

to

==========
Extension Docs: Document asyncBlocking in the Web Request API Docs.

BUG=695607

Review-Url: https://codereview.chromium.org/2714023002
Cr-Commit-Position: refs/heads/master@{#452755}
Committed:
https://chromium.googlesource.com/chromium/src/+/805486b4386ec845de6098bb9ff5...
==========

[commit-bot: I haz the power, 2017-02-24 05:12:33]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/805486b4386ec845de6098bb9ff5...