Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2714023002: Extension Docs: Document asyncBlocking in the Web Request API Docs. (Closed)

Created:
3 years, 10 months ago by karandeepb
Modified:
3 years, 10 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extension Docs: Document asyncBlocking in the Web Request API Docs. BUG=695607 Review-Url: https://codereview.chromium.org/2714023002 Cr-Commit-Position: refs/heads/master@{#452755} Committed: https://chromium.googlesource.com/chromium/src/+/805486b4386ec845de6098bb9ff58521089d51eb

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/common/extensions/docs/templates/intros/webRequest.html View 1 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/common/api/web_request.json View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
karandeepb
PTAL Istiaque.
3 years, 10 months ago (2017-02-23 22:56:14 UTC) #3
lazyboy
https://codereview.chromium.org/2714023002/diff/1/chrome/common/extensions/docs/templates/intros/webRequest.html File chrome/common/extensions/docs/templates/intros/webRequest.html (right): https://codereview.chromium.org/2714023002/diff/1/chrome/common/extensions/docs/templates/intros/webRequest.html#newcode215 chrome/common/extensions/docs/templates/intros/webRequest.html:215: <code>onAuthRequired</code>), the extension can generate the <code>onAuthRequired</code> event), ...
3 years, 10 months ago (2017-02-24 00:17:22 UTC) #4
karandeepb
PTAL Istiaque. https://codereview.chromium.org/2714023002/diff/1/chrome/common/extensions/docs/templates/intros/webRequest.html File chrome/common/extensions/docs/templates/intros/webRequest.html (right): https://codereview.chromium.org/2714023002/diff/1/chrome/common/extensions/docs/templates/intros/webRequest.html#newcode215 chrome/common/extensions/docs/templates/intros/webRequest.html:215: <code>onAuthRequired</code>), the extension can generate the On ...
3 years, 10 months ago (2017-02-24 01:04:40 UTC) #6
lazyboy
lgtm
3 years, 10 months ago (2017-02-24 01:39:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2714023002/40001
3 years, 10 months ago (2017-02-24 04:11:03 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 05:12:33 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/805486b4386ec845de6098bb9ff5...

Powered by Google App Engine
This is Rietveld 408576698