Remove toggle button code from Tab Strip.

Remove toggle button code from Tab Strip.

The button to toggle between incognito and non incognito is not used anymore.

This CL:
* removes the code that handled that button.
* renames the Tab Switcher button from _tabSwitcherToggleButton to
|_tabSwitcherButton|, as well as the other companion variables.
* fixes an issue in |tabStripVisibleSpace| where only the presence of the toggle
button was considered, not the presence of the tab switcher button.

BUG=687132
Review-Url: https://codereview.chromium.org/2714003003
Cr-Commit-Position: refs/heads/master@{#455166}
Committed: https://chromium.googlesource.com/chromium/src/+/be26050c964a17ced5964a2508461ec780048a33

[jif, 2017-02-24 10:36:07]

Description was changed from

==========
Clean up tab strip.

BUG=None.
==========

to

==========
Remove toggle button code from Tab Strip.

BUG=687132
==========

[jif, 2017-02-24 10:39:55]

Description was changed from

==========
Remove toggle button code from Tab Strip.

BUG=687132
==========

to

==========
Remove toggle button code from Tab Strip.

The button to toggle between incognito and non incognito is not used anymore.

This CL:
* removes the code that handled that button.
* renames the Tab Switcher button from _tabSwitcherToggleButton to
|_tabSwitcherButton|, as well as the other companion variables.
* fixes an issue in |tabStripVisibleSpace| where only the presence of the toggle
button was considered, not the presence of the tab switcher button.

BUG=687132
==========

[jif, 2017-02-24 10:41:12]

Patchset #1 (id:1) has been deleted

[jif, 2017-02-24 10:42:08]

jif@chromium.org changed reviewers:
+ rohitrao@chromium.org

[jif, 2017-02-24 10:42:14]

ptal

[jif, 2017-03-06 15:29:51]

ping

[rohitrao (ping after 24h), 2017-03-07 12:45:13]

lgtm

[jif, 2017-03-07 17:08:24]

The CQ bit was checked by jif@chromium.org

[commit-bot: I haz the power, 2017-03-07 17:09:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 19:01:57]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488906504329250,
"parent_rev": "8212d5a7aeeea89a24a3c01c4bd51dc10bf03d1f", "commit_rev":
"be26050c964a17ced5964a2508461ec780048a33"}

[commit-bot: I haz the power, 2017-03-07 19:05:52]

Description was changed from

==========
Remove toggle button code from Tab Strip.

The button to toggle between incognito and non incognito is not used anymore.

This CL:
* removes the code that handled that button.
* renames the Tab Switcher button from _tabSwitcherToggleButton to
|_tabSwitcherButton|, as well as the other companion variables.
* fixes an issue in |tabStripVisibleSpace| where only the presence of the toggle
button was considered, not the presence of the tab switcher button.

BUG=687132
==========

to

==========
Remove toggle button code from Tab Strip.

The button to toggle between incognito and non incognito is not used anymore.

This CL:
* removes the code that handled that button.
* renames the Tab Switcher button from _tabSwitcherToggleButton to
|_tabSwitcherButton|, as well as the other companion variables.
* fixes an issue in |tabStripVisibleSpace| where only the presence of the toggle
button was considered, not the presence of the tab switcher button.

BUG=687132

Review-Url: https://codereview.chromium.org/2714003003
Cr-Commit-Position: refs/heads/master@{#455166}
Committed:
https://chromium.googlesource.com/chromium/src/+/be26050c964a17ced5964a250846...
==========

[commit-bot: I haz the power, 2017-03-07 19:05:53]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/be26050c964a17ced5964a250846...