Issue 2713993004: Update CRIWVWebClient prefix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2713993004: Update CRIWVWebClient prefix. (Closed)

Created:
3 years, 10 months ago by michaeldo

Modified:
3 years, 10 months ago

Reviewers:
Eugene But (OOO till 7-30)

CC:
chromium-reviews, Eugene But (OOO till 7-30)

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Update CRIWVWebClient prefix. BUG=690807

Patch Set 1 #

Total comments: 1

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -119 lines)			Patch
M	ios/web_view/internal/BUILD.gn	View	2 chunks	+2 lines, -2 lines	0 comments	Download
D	ios/web_view/internal/criwv_web_client.h	View	1 chunk	+0 lines, -47 lines	0 comments	Download
D	ios/web_view/internal/criwv_web_client.mm	View	1 chunk	+0 lines, -46 lines	0 comments	Download
M	ios/web_view/internal/criwv_web_main_delegate.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ios/web_view/internal/criwv_web_main_delegate.mm	View	2 chunks	+2 lines, -2 lines	0 comments	Download
A +	ios/web_view/internal/cwv_web_client.h	View	3 chunks	+7 lines, -7 lines	1 comment	Download
A +	ios/web_view/internal/cwv_web_client.mm	View	2 chunks	+8 lines, -8 lines	0 comments	Download
M	ios/web_view/internal/cwv_website_data_store.mm	View	3 chunks	+5 lines, -5 lines	0 comments	Download

Depends on Patchset:

Issue 2713243002 Patch 1

Dependent Patchsets:

Issue 2714943003 Patch 1

Messages

Total messages: 4 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Eugene But (OOO till 7-30)

3 years, 10 months ago (2017-02-24 19:44:02 UTC) #3

https://codereview.chromium.org/2713993004/diff/1/ios/web_view/internal/cwv_w...
File ios/web_view/internal/cwv_web_client.h (right):

https://codereview.chromium.org/2713993004/diff/1/ios/web_view/internal/cwv_w...
ios/web_view/internal/cwv_web_client.h:20: class CWVWebClient : public
web::WebClient {
Per comments from the previous CL, 3 letter prefix is used only for Objective-C
classes.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages