Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2713243002: Rename CRIWVURLRequestContextGetter prefix. (Closed)

Created:
3 years, 10 months ago by michaeldo
Modified:
3 years, 9 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename CRIWVURLRequestContextGetter prefix. BUG=690807

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -245 lines) Patch
M ios/web_view/internal/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
D ios/web_view/internal/criwv_url_request_context_getter.h View 1 chunk +0 lines, -61 lines 0 comments Download
D ios/web_view/internal/criwv_url_request_context_getter.mm View 1 chunk +0 lines, -166 lines 0 comments Download
M ios/web_view/internal/cwv_browser_state.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web_view/internal/cwv_browser_state.mm View 2 chunks +2 lines, -2 lines 0 comments Download
A + ios/web_view/internal/cwv_url_request_context_getter.h View 4 chunks +7 lines, -7 lines 1 comment Download
A + ios/web_view/internal/cwv_url_request_context_getter.mm View 4 chunks +5 lines, -5 lines 0 comments Download

Depends on Patchset:

Issue 2715603002 Patch 1

Dependent Patchsets:

Issue 2713993004 Patch 1

Messages

Total messages: 5 (2 generated)
michaeldo
3 years, 10 months ago (2017-02-24 18:17:07 UTC) #2
Eugene But (OOO till 7-30)
https://codereview.chromium.org/2713243002/diff/1/ios/web_view/internal/cwv_url_request_context_getter.h File ios/web_view/internal/cwv_url_request_context_getter.h (right): https://codereview.chromium.org/2713243002/diff/1/ios/web_view/internal/cwv_url_request_context_getter.h#newcode27 ios/web_view/internal/cwv_url_request_context_getter.h:27: class CWVURLRequestContextGetter : public net::URLRequestContextGetter { 3-letter prefixes are ...
3 years, 10 months ago (2017-02-24 18:42:53 UTC) #4
michaeldo
3 years, 10 months ago (2017-02-24 23:52:13 UTC) #5 
On 2017/02/24 18:42:53, Eugene But wrote:
>
https://codereview.chromium.org/2713243002/diff/1/ios/web_view/internal/cwv_u...
> File ios/web_view/internal/cwv_url_request_context_getter.h (right):
> 
>
https://codereview.chromium.org/2713243002/diff/1/ios/web_view/internal/cwv_u...
> ios/web_view/internal/cwv_url_request_context_getter.h:27: class
> CWVURLRequestContextGetter : public net::URLRequestContextGetter {
> 3-letter prefixes are used only for Objective-C classes, because Objective-C
> does not have namespaces.
> This should follow the same pattern as ShellURLRequestContextGetter name.
Maybe
> WebViewURLRequestContextGetter?

Ah, yes you're right. Sorry, I wasn't up to date on email when I was making
these CLs. I have a new CL in the works to update the C++ classes together as
the individual CLs take too much time individually to create and land.

Powered by Google App Engine
This is Rietveld 408576698