Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2713993002: RecentTabHelper: adds DVLOG and reload unit test. (Closed)

Created:
3 years, 10 months ago by carlosk
Modified:
3 years, 10 months ago
Reviewers:
Dmitry Titov
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

RecentTabHelper: adds DVLOG and reload unit test. This change adds many DVLOG entries to RecentTabHelper to help debugging it when needed. This is a debug-build-only change so the added strings should not affect release binary size. The new reload test checks that this kind of navigation is properly handled as a full reload of the page (as opposed to same-page navigations which are "ignored" as loads). BUG=685791 Review-Url: https://codereview.chromium.org/2713993002 Cr-Commit-Position: refs/heads/master@{#452877} Committed: https://chromium.googlesource.com/chromium/src/+/d5f450e8a4185ba2e78f76770acc63586f80ad2a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -7 lines) Patch
M chrome/browser/android/offline_pages/recent_tab_helper.cc View 12 chunks +47 lines, -7 lines 0 comments Download
M chrome/browser/android/offline_pages/recent_tab_helper_unittest.cc View 2 chunks +32 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
carlosk
dimich@ PTAL.
3 years, 10 months ago (2017-02-23 21:53:53 UTC) #4
Dmitry Titov
lgtm
3 years, 10 months ago (2017-02-24 04:38:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2713993002/1
3 years, 10 months ago (2017-02-24 18:19:45 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 18:25:08 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d5f450e8a4185ba2e78f76770acc...

Powered by Google App Engine
This is Rietveld 408576698