Convert more PannerNode tests to testharness

Convert more PannerNode tests to testharness

Manually convert these PannerNode tests to use testharness and new
Audit.

BUG=688456
TEST=panner-automation-equalpower-stereo.html,
panner-equalpower-stereo.html,
panner-equalpower.html,
panner-loop.html

Review-Url: https://codereview.chromium.org/2713943002
Cr-Commit-Position: refs/heads/master@{#452988}
Committed: https://chromium.googlesource.com/chromium/src/+/fdc4e40323d4c151cd255635396e2af4089b366b

[Raymond Toy, 2017-02-23 20:13:27]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2017-02-23 20:13:28]

PTAL

[hongchan, 2017-02-24 22:07:24]

lgtm with nits

https://codereview.chromium.org/2713943002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/Panner/panner-automation-equalpower-stereo.html
(right):

https://codereview.chromium.org/2713943002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/Panner/panner-automation-equalpower-stereo.html:15:
//description("Test equal-power panner model of AudioPannerNode with stereo
source.");
We don't need this anymore. Right?

https://codereview.chromium.org/2713943002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/Panner/panner-equalpower-stereo.html
(right):

https://codereview.chromium.org/2713943002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/Panner/panner-equalpower-stereo.html:28:
// Create offline audio context.
A redundant comment. Should we remove?

https://codereview.chromium.org/2713943002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/webaudio/resources/panner-model-testing.js
(right):

https://codereview.chromium.org/2713943002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/resources/panner-model-testing.js:65:
function createTestAndRun(context, should, nodeCount, numberOfSourceChannels,
positionSetter) {
Let's wrap this line.

https://codereview.chromium.org/2713943002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/resources/panner-model-testing.js:71:
.then(buffer => checkResult(buffer, should));;
Two semicolons.

[Raymond Toy, 2017-02-24 22:19:24]

https://codereview.chromium.org/2713943002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/Panner/panner-automation-equalpower-stereo.html
(right):

https://codereview.chromium.org/2713943002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/Panner/panner-automation-equalpower-stereo.html:15:
//description("Test equal-power panner model of AudioPannerNode with stereo
source.");
On 2017/02/24 22:07:24, hongchan wrote:
> We don't need this anymore. Right?

Done.

https://codereview.chromium.org/2713943002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/Panner/panner-equalpower-stereo.html
(right):

https://codereview.chromium.org/2713943002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/Panner/panner-equalpower-stereo.html:28:
// Create offline audio context.
On 2017/02/24 22:07:24, hongchan wrote:
> A redundant comment. Should we remove?

Done.

https://codereview.chromium.org/2713943002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/webaudio/resources/panner-model-testing.js
(right):

https://codereview.chromium.org/2713943002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/resources/panner-model-testing.js:65:
function createTestAndRun(context, should, nodeCount, numberOfSourceChannels,
positionSetter) {
On 2017/02/24 22:07:24, hongchan wrote:
> Let's wrap this line.

Done.

https://codereview.chromium.org/2713943002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/resources/panner-model-testing.js:71:
.then(buffer => checkResult(buffer, should));;
On 2017/02/24 22:07:24, hongchan wrote:
> Two semicolons.

Done.

[Raymond Toy, 2017-02-24 22:19:32]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2017-02-24 22:19:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2713943002/#ps20001
(title: "Address review comments")

[commit-bot: I haz the power, 2017-02-24 22:20:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 23:20:32]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487974772988310,
"parent_rev": "264a0dd42bb8612ab0d2d60645e722a7758b013e", "commit_rev":
"fdc4e40323d4c151cd255635396e2af4089b366b"}

[commit-bot: I haz the power, 2017-02-24 23:21:09]

Description was changed from

==========
Convert more PannerNode tests to testharness

Manually convert these PannerNode tests to use testharness and new
Audit.

BUG=688456
TEST=panner-automation-equalpower-stereo.html,
panner-equalpower-stereo.html,
panner-equalpower.html,
panner-loop.html
==========

to

==========
Convert more PannerNode tests to testharness

Manually convert these PannerNode tests to use testharness and new
Audit.

BUG=688456
TEST=panner-automation-equalpower-stereo.html,
panner-equalpower-stereo.html,
panner-equalpower.html,
panner-loop.html

Review-Url: https://codereview.chromium.org/2713943002
Cr-Commit-Position: refs/heads/master@{#452988}
Committed:
https://chromium.googlesource.com/chromium/src/+/fdc4e40323d4c151cd255635396e...
==========

[commit-bot: I haz the power, 2017-02-24 23:21:10]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fdc4e40323d4c151cd255635396e...