chromeos: moves a bunch of tests to common_unittests

chromeos: moves a bunch of tests to common_unittests

These all work with both ash and mash now. I've had to effectively
disable some for mash only, and have filed bugs.

TEST=test only change
BUG=695556, 695559, 695562, 695563, 695561, 695563, 695565, 695566, 695569, 695570
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2713923002
Cr-Commit-Position: refs/heads/master@{#452652}
Committed: https://chromium.googlesource.com/chromium/src/+/8782ff08a3ed45882f707658d63cb25cf403187f

[sky, 2017-02-23 19:36:09]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 19:36:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2017-02-23 20:34:01]

lgtm with nits and an aside q

https://codereview.chromium.org/2713923002/diff/20001/ash/BUILD.gn
File ash/BUILD.gn (right):

https://codereview.chromium.org/2713923002/diff/20001/ash/BUILD.gn#newcode1270
ash/BUILD.gn:1270: # TODO: move to common_unittests. http://crbug.com/693790 is
fixed.
nit s/./ when/?

https://codereview.chromium.org/2713923002/diff/20001/ash/accelerators/accele...
File ash/accelerators/accelerator_filter_unittest.cc (right):

https://codereview.chromium.org/2713923002/diff/20001/ash/accelerators/accele...
ash/accelerators/accelerator_filter_unittest.cc:38: // TODO: mash doesn't
support ScreeShotDelgate yet. http://crbug.com/632111.
nit: ScreenshotDelegate here and twice more below

https://codereview.chromium.org/2713923002/diff/20001/ash/extended_desktop_un...
File ash/extended_desktop_unittest.cc (right):

https://codereview.chromium.org/2713923002/diff/20001/ash/extended_desktop_un...
ash/extended_desktop_unittest.cc:39:
Shell::GetInstance()->display_manager()->GetCurrentDisplayLayout().Copy();
aside: I wonder how this works in mash (isn't there no display_manager?)

[sky, 2017-02-23 20:48:27]

https://codereview.chromium.org/2713923002/diff/20001/ash/BUILD.gn
File ash/BUILD.gn (right):

https://codereview.chromium.org/2713923002/diff/20001/ash/BUILD.gn#newcode1270
ash/BUILD.gn:1270: # TODO: move to common_unittests. http://crbug.com/693790 is
fixed.
On 2017/02/23 20:34:01, msw wrote:
> nit s/./ when/?

Done.

https://codereview.chromium.org/2713923002/diff/20001/ash/accelerators/accele...
File ash/accelerators/accelerator_filter_unittest.cc (right):

https://codereview.chromium.org/2713923002/diff/20001/ash/accelerators/accele...
ash/accelerators/accelerator_filter_unittest.cc:38: // TODO: mash doesn't
support ScreeShotDelgate yet. http://crbug.com/632111.
On 2017/02/23 20:34:01, msw wrote:
> nit: ScreenshotDelegate here and twice more below

Done.

https://codereview.chromium.org/2713923002/diff/20001/ash/extended_desktop_un...
File ash/extended_desktop_unittest.cc (right):

https://codereview.chromium.org/2713923002/diff/20001/ash/extended_desktop_un...
ash/extended_desktop_unittest.cc:39:
Shell::GetInstance()->display_manager()->GetCurrentDisplayLayout().Copy();
On 2017/02/23 20:34:01, msw wrote:
> aside: I wonder how this works in mash (isn't there no display_manager?)

It doesn't. This class isn't in common_unittests. The changes I did below aren't
necessary at this time, but I did them assuming at some point we will want this
class to work in mash.

[sky, 2017-02-23 20:48:38]

The CQ bit was checked by sky@chromium.org

[sky, 2017-02-23 20:48:39]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2713923002/#ps40001
(title: "feedback")

[commit-bot: I haz the power, 2017-02-23 20:48:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 22:12:46]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487882918724650,
"parent_rev": "f873893f91b3330c2194c9dab8af4be4822c6480", "commit_rev":
"8782ff08a3ed45882f707658d63cb25cf403187f"}

[commit-bot: I haz the power, 2017-02-23 22:13:30]

Description was changed from

==========
chromeos: moves a bunch of tests to common_unittests

These all work with both ash and mash now. I've had to effectively
disable some for mash only, and have filed bugs.

TEST=test only change
BUG=695556,695559,695562,695563,695561,695563,695565,695566,695569,695570
R=msw@chromium.org
==========

to

==========
chromeos: moves a bunch of tests to common_unittests

These all work with both ash and mash now. I've had to effectively
disable some for mash only, and have filed bugs.

TEST=test only change
BUG=695556,695559,695562,695563,695561,695563,695565,695566,695569,695570
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2713923002
Cr-Commit-Position: refs/heads/master@{#452652}
Committed:
https://chromium.googlesource.com/chromium/src/+/8782ff08a3ed45882f707658d63c...
==========

[commit-bot: I haz the power, 2017-02-23 22:13:38]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8782ff08a3ed45882f707658d63c...