Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2713903002: Move spin_lock into partition_allocator. (Closed)

Created:
3 years, 10 months ago by palmer
Modified:
3 years, 9 months ago
Reviewers:
haraken, Nico, dcheng
CC:
Mads Ager (chromium), blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Dai Mikurube (NOT FULLTIME), kinuko+watch, kouhei+heap_chromium.org, Mikhail, oilpan-reviews, vmpstr+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move spin_lock into partition_allocator. This helps make partition_alloc more self-contained. BUG=695274 Review-Url: https://codereview.chromium.org/2713903002 Cr-Commit-Position: refs/heads/master@{#453414} Committed: https://chromium.googlesource.com/chromium/src/+/5caa9cbf4796054a6094d9606a7cca4b0013df94

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Remove unnecessary DEPS line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -157 lines) Patch
M base/BUILD.gn View 1 2 1 chunk +2 lines, -9 lines 0 comments Download
M base/allocator/partition_allocator/address_space_randomization.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/allocator/partition_allocator/partition_alloc.h View 1 chunk +1 line, -1 line 0 comments Download
M base/allocator/partition_allocator/partition_alloc.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + base/allocator/partition_allocator/spin_lock.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + base/allocator/partition_allocator/spin_lock.cc View 1 chunk +1 line, -1 line 0 comments Download
D base/synchronization/spin_lock.h View 1 chunk +0 lines, -52 lines 0 comments Download
D base/synchronization/spin_lock.cc View 1 chunk +0 lines, -82 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/DEPS View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/SpinLock.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/wtf/allocator/Partitions.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
palmer
3 years, 10 months ago (2017-02-23 18:56:29 UTC) #2
palmer
thakis owns everything I touch in this CL, but haraken FYI also.
3 years, 10 months ago (2017-02-23 18:57:55 UTC) #6
haraken
partition_alloc/ LGTM
3 years, 10 months ago (2017-02-23 21:40:43 UTC) #13
palmer
dcheng: Can you please take a look as a base/ OWNER? Thanks!
3 years, 9 months ago (2017-02-27 20:57:32 UTC) #15
dcheng
base lgtm
3 years, 9 months ago (2017-02-27 21:53:22 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2713903002/40001
3 years, 9 months ago (2017-02-27 22:17:08 UTC) #19
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 00:35:11 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5caa9cbf4796054a6094d9606a7c...

Powered by Google App Engine
This is Rietveld 408576698