Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1285)

Issue 2713833002: Convert LayoutTests/svg/dom/SVGAnimated*.html js-tests.js to testharness.js based tests. (Closed)

Created:
3 years, 10 months ago by Shanmuga Pandi
Modified:
3 years, 10 months ago
Reviewers:
Srirama, fs
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert LayoutTests/svg/dom/SVGAnimated*.html js-tests.js to testharness.js based tests. BUG=636710 Review-Url: https://codereview.chromium.org/2713833002 Cr-Commit-Position: refs/heads/master@{#452461} Committed: https://chromium.googlesource.com/chromium/src/+/18a777a3dcb3b973d01a1f14b5ab321f31e39aa4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -287 lines) Patch
M third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedLength.html View 1 chunk +33 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedLength-expected.txt View 1 chunk +0 lines, -27 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedLengthList.html View 1 chunk +34 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedLengthList-expected.txt View 1 chunk +0 lines, -27 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedNumber.html View 1 chunk +42 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedNumber-expected.txt View 1 chunk +0 lines, -35 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedNumberList.html View 1 chunk +34 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedNumberList-expected.txt View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/script-tests/SVGAnimatedLength.js View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/script-tests/SVGAnimatedLengthList.js View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/script-tests/SVGAnimatedNumber.js View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/script-tests/SVGAnimatedNumberList.js View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Shanmuga Pandi
PTAL!!
3 years, 10 months ago (2017-02-23 09:49:59 UTC) #2
fs
lgtm
3 years, 10 months ago (2017-02-23 10:07:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2713833002/1
3 years, 10 months ago (2017-02-23 10:08:36 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 11:28:40 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/18a777a3dcb3b973d01a1f14b5ab...

Powered by Google App Engine
This is Rietveld 408576698