[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS files
(*installer, chrome_elf, etc). Thanks.

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=robertshield@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2713793003
Cr-Commit-Position: refs/heads/master@{#453422}
Committed: https://chromium.googlesource.com/chromium/src/+/021fec426c6ee045b5d202bb4db2472bfe77d1de

[ymzhang1, 2017-02-23 19:14:16]

Description was changed from

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file. Please help us to
verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your
OWNERS files(*installer, chrome_elf, etc). Thanks.

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=robertshield@chromium.org
==========

to

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file. Please help us to
verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your
OWNERS files(*installer, chrome_elf, etc). Thanks.

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=robertshield@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

[ymzhang1, 2017-02-23 19:14:47]

Hello,

We are adding COMPONENT/TEAM information into OWNERS file. Would you mind
helping us to verify the added TEAM/COMPONENT or suggest the correct
TEAM/COMPONENT in your OWNERS files? Thank you very much!

[robertshield, 2017-02-23 21:30:28]

robertshield@chromium.org changed reviewers:
+ grt@google.com

[robertshield, 2017-02-23 21:30:29]

https://codereview.chromium.org/2713793003/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/incident_reporting/OWNERS (right):

https://codereview.chromium.org/2713793003/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/incident_reporting/OWNERS:5: # COMPONENT:
Internals>Network
This should be Services>SafeBrowsing

https://codereview.chromium.org/2713793003/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/settings_reset_prompt/OWNERS (right):

https://codereview.chromium.org/2713793003/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/settings_reset_prompt/OWNERS:4: # COMPONENT:
Internals>Network
This should be UI>Browser>Preferences>Protector

https://codereview.chromium.org/2713793003/diff/1/google_update/OWNERS
File google_update/OWNERS (right):

https://codereview.chromium.org/2713793003/diff/1/google_update/OWNERS#newcode4
google_update/OWNERS:4: # COMPONENT: Internals>Core
Probably Internals>Installer

[robertshield, 2017-02-23 21:30:49]

On 2017/02/23 21:30:29, robertshield wrote:
>
https://codereview.chromium.org/2713793003/diff/1/chrome/browser/safe_browsin...
> File chrome/browser/safe_browsing/incident_reporting/OWNERS (right):
> 
>
https://codereview.chromium.org/2713793003/diff/1/chrome/browser/safe_browsin...
> chrome/browser/safe_browsing/incident_reporting/OWNERS:5: # COMPONENT:
> Internals>Network
> This should be Services>SafeBrowsing
> 
>
https://codereview.chromium.org/2713793003/diff/1/chrome/browser/safe_browsin...
> File chrome/browser/safe_browsing/settings_reset_prompt/OWNERS (right):
> 
>
https://codereview.chromium.org/2713793003/diff/1/chrome/browser/safe_browsin...
> chrome/browser/safe_browsing/settings_reset_prompt/OWNERS:4: # COMPONENT:
> Internals>Network
> This should be UI>Browser>Preferences>Protector
> 
> https://codereview.chromium.org/2713793003/diff/1/google_update/OWNERS
> File google_update/OWNERS (right):
> 
>
https://codereview.chromium.org/2713793003/diff/1/google_update/OWNERS#newcode4
> google_update/OWNERS:4: # COMPONENT: Internals>Core
> Probably Internals>Installer

(+cc grt@ to comment on installer component choices)

[grt (UTC plus 2), 2017-02-23 22:00:15]

grt@chromium.org changed reviewers:
+ grt@chromium.org

[grt (UTC plus 2), 2017-02-23 22:00:16]

https://codereview.chromium.org/2713793003/diff/1/chrome/browser/install_veri...
File chrome/browser/install_verification/OWNERS (right):

https://codereview.chromium.org/2713793003/diff/1/chrome/browser/install_veri...
chrome/browser/install_verification/OWNERS:4: # COMPONENT: Internals>Installer
Internals>PlatformIntegration

https://codereview.chromium.org/2713793003/diff/1/google_update/OWNERS
File google_update/OWNERS (right):

https://codereview.chromium.org/2713793003/diff/1/google_update/OWNERS#newcode4
google_update/OWNERS:4: # COMPONENT: Internals>Core
On 2017/02/23 21:30:29, robertshield wrote:
> Probably Internals>Installer

Agreed.

[ymzhang1, 2017-02-23 22:06:23]

Description was changed from

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file. Please help us to
verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your
OWNERS files(*installer, chrome_elf, etc). Thanks.

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=robertshield@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

to

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file. (*installer,
chrome_elf, etc). Thanks.

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=robertshield@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

[ymzhang1, 2017-02-23 22:06:41]

Description was changed from

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file. (*installer,
chrome_elf, etc). Thanks.

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=robertshield@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

to

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS files
(*installer, chrome_elf, etc). Thanks.

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=robertshield@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

[ymzhang1, 2017-02-23 22:07:33]

Thanks very much for the comments!

https://codereview.chromium.org/2713793003/diff/1/chrome/browser/install_veri...
File chrome/browser/install_verification/OWNERS (right):

https://codereview.chromium.org/2713793003/diff/1/chrome/browser/install_veri...
chrome/browser/install_verification/OWNERS:4: # COMPONENT: Internals>Installer
On 2017/02/23 22:00:16, grt (UTC plus 1) wrote:
> Internals>PlatformIntegration

Done.

https://codereview.chromium.org/2713793003/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/incident_reporting/OWNERS (right):

https://codereview.chromium.org/2713793003/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/incident_reporting/OWNERS:5: # COMPONENT:
Internals>Network
On 2017/02/23 21:30:28, robertshield wrote:
> This should be Services>SafeBrowsing

Done.

https://codereview.chromium.org/2713793003/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/settings_reset_prompt/OWNERS (right):

https://codereview.chromium.org/2713793003/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/settings_reset_prompt/OWNERS:4: # COMPONENT:
Internals>Network
On 2017/02/23 21:30:29, robertshield wrote:
> This should be UI>Browser>Preferences>Protector

Done.

https://codereview.chromium.org/2713793003/diff/1/google_update/OWNERS
File google_update/OWNERS (right):

https://codereview.chromium.org/2713793003/diff/1/google_update/OWNERS#newcode4
google_update/OWNERS:4: # COMPONENT: Internals>Core
On 2017/02/23 22:00:16, grt (UTC plus 1) wrote:
> On 2017/02/23 21:30:29, robertshield wrote:
> > Probably Internals>Installer
> 
> Agreed.

Done.

[grt (UTC plus 2), 2017-02-24 20:49:11]

lgtm for the bits i commented on. thanks.

[robertshield, 2017-02-27 23:48:17]

lgtm

[ymzhang1, 2017-02-27 23:48:30]

The CQ bit was checked by ymzhang@chromium.org

[commit-bot: I haz the power, 2017-02-27 23:48:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 00:44:10]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488239310518090,
"parent_rev": "3cb9fa02e282b950b408a934d98d89c088b87cfc", "commit_rev":
"fa54c4295df2a93ee946b61327c17d76c3cad646"}

[commit-bot: I haz the power, 2017-02-28 00:49:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488239310518090,
"parent_rev": "bd0fec203d70c05164f50cbc258e34bde942e470", "commit_rev":
"021fec426c6ee045b5d202bb4db2472bfe77d1de"}

[commit-bot: I haz the power, 2017-02-28 00:49:46]

Description was changed from

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS files
(*installer, chrome_elf, etc). Thanks.

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=robertshield@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

to

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS files
(*installer, chrome_elf, etc). Thanks.

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=robertshield@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2713793003
Cr-Commit-Position: refs/heads/master@{#453422}
Committed:
https://chromium.googlesource.com/chromium/src/+/021fec426c6ee045b5d202bb4db2...
==========

[commit-bot: I haz the power, 2017-02-28 00:49:47]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/021fec426c6ee045b5d202bb4db2...