Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Unified Diff: content/browser/frame_host/navigation_entry_impl.cc

Issue 2713743002: Remove DumpWithoutCrashing calls for empty PageState. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_entry_impl.cc
diff --git a/content/browser/frame_host/navigation_entry_impl.cc b/content/browser/frame_host/navigation_entry_impl.cc
index 880d0a21ae843f87d6f31d1b9420e18059526fae..0abc9fcbc11ebb0131be423aba04ebee40c575a4 100644
--- a/content/browser/frame_host/navigation_entry_impl.cc
+++ b/content/browser/frame_host/navigation_entry_impl.cc
@@ -9,7 +9,6 @@
#include <queue>
#include <utility>
-#include "base/debug/dump_without_crashing.h"
#include "base/i18n/rtl.h"
#include "base/memory/ptr_util.h"
#include "base/metrics/histogram_macros.h"
@@ -66,11 +65,6 @@ void RecursivelyGenerateFrameEntries(
page_state.top = state;
std::string data;
EncodePageState(page_state, &data);
- if (data.empty()) {
- // Temporarily generate a minidump to diagnose https://crbug.com/568703.
- base::debug::DumpWithoutCrashing();
- NOTREACHED() << "Shouldn't generate an empty PageState.";
alexmos 2017/02/23 18:05:12 Just to make sure -- do we want to remove everythi
Charlie Reis 2017/02/28 05:30:57 Sure, a DCHECK makes sense here.
- }
node->frame_entry->SetPageState(PageState::CreateFromEncodedData(data));
// Don't pass the file list to subframes, since that would result in multiple

Powered by Google App Engine
This is Rietveld 408576698