Remove DumpWithoutCrashing calls for empty PageState.

content/browser/frame_host/navigation_entry_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/navigation_entry_impl.h"
 
 #include <stddef.h>
 
 #include <queue>
 #include <utility>
 
-#include "base/debug/dump_without_crashing.h"
 #include "base/i18n/rtl.h"
 #include "base/memory/ptr_util.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "components/url_formatter/url_formatter.h"
 #include "content/common/content_constants_internal.h"
 #include "content/common/navigation_params.h"
 #include "content/common/page_state_serialization.h"
@@ skipping 36 matching lines @@
   // frame's PageState.  (We don't pass the list to subframes below.)
   // TODO(creis): Grant access to this list for each process that renders
   // this page, even for OOPIFs.  Eventually keep track of a verified list of
   // files per frame, so that we only grant access to processes that need it.
   if (referenced_files.size() > 0)
     page_state.referenced_files = referenced_files;
 
   page_state.top = state;
   std::string data;
   EncodePageState(page_state, &data);
-  if (data.empty()) {
-    // Temporarily generate a minidump to diagnose https://crbug.com/568703.
-    base::debug::DumpWithoutCrashing();
-    NOTREACHED() << "Shouldn't generate an empty PageState.";

[alexmos, 2017/02/23 18:05:12]

Just to make sure -- do we want to remove everything here, or keep the
NOTREACHED and just remove the DWOC?

[Charlie Reis, 2017/02/28 05:30:57]

Sure, a DCHECK makes sense here.

-  }
   node->frame_entry->SetPageState(PageState::CreateFromEncodedData(data));
 
   // Don't pass the file list to subframes, since that would result in multiple
   // copies of it ending up in the combined list in GetPageState (via
   // RecursivelyGenerateFrameState).
   std::vector<base::NullableString16> empty_file_list;
 
   for (const ExplodedFrameState& child_state : state.children) {
     NavigationEntryImpl::TreeNode* child_node =
         new NavigationEntryImpl::TreeNode(node, nullptr);
@@ skipping 868 matching lines @@
       return node;
 
     // Enqueue any children and keep looking.
     for (auto* child : node->children)
       work_queue.push(child);
   }
   return nullptr;
 }
 
 }  // namespace content