Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2713733002: [wasm] Block compile/instantiate of large array buffers (Closed)

Created:
3 years, 10 months ago by bradnelson
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[wasm] Block compile/instantiate of large array buffers To discourage development patterns leading to bad user experience, we block wasm compilation/instantiation through the sync APIs for modules larger than a certain size. Promise-based APIs still succeed; also, sync APIs succeed in worker contexts. BUG=693945 R=bradnelson@chromium.org,esprehn@chromium.org,jochen@chromium.org Review-Url: https://codereview.chromium.org/2702953002 Cr-Commit-Position: refs/heads/master@{#451811} (cherry picked from commit 50e18a2d44ebf8da875090bf9f0a4645d6741d23) Review-Url: https://codereview.chromium.org/2713733002 . Cr-Commit-Position: refs/branch-heads/2987@{#647} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/182ba2ea22eb0371d728d8dfbfcdb95408e7fd8d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1143 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/wasm/wasm-constants.js View 1 chunk +376 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/wasm/wasm-limits-test.html View 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/wasm/wasm-limits-tests.js View 1 chunk +67 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/wasm/wasm-limits-tests-common.js View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/wasm/wasm-limits-worker.js View 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/wasm/wasm-module-builder.js View 1 chunk +581 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp View 3 chunks +48 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
bradnelson
3 years, 10 months ago (2017-02-22 22:45:31 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
182ba2ea22eb0371d728d8dfbfcdb95408e7fd8d.

Powered by Google App Engine
This is Rietveld 408576698