Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 2713713002: Reconstitute const-ref parameter to set_scroll_chain_and_layer_tree (Closed)

Created:
3 years, 10 months ago by pdr.
Modified:
3 years, 10 months ago
Reviewers:
bokan, ajuma
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reconstitute const-ref parameter to set_scroll_chain_and_layer_tree This was mistakenly removed in https://codereview.chromium.org/2708493002 BUG=693740 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2713713002 Cr-Commit-Position: refs/heads/master@{#452270} Committed: https://chromium.googlesource.com/chromium/src/+/5b0518aededd5260a9fde6669b690ef705ef5234

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M cc/input/scroll_state.h View 1 chunk +4 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (11 generated)
pdr.
3 years, 10 months ago (2017-02-22 21:33:42 UTC) #3
pdr.
"Reconstitute" XD
3 years, 10 months ago (2017-02-22 21:36:33 UTC) #4
bokan
On 2017/02/22 21:36:33, pdr. wrote: > "Reconstitute" XD Thanks, lgtm
3 years, 10 months ago (2017-02-22 21:45:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2713713002/1
3 years, 10 months ago (2017-02-22 21:55:00 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/370567)
3 years, 10 months ago (2017-02-22 22:04:05 UTC) #12
ajuma
lgtm
3 years, 10 months ago (2017-02-22 22:19:10 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2713713002/1
3 years, 10 months ago (2017-02-22 22:20:20 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 23:30:48 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5b0518aededd5260a9fde6669b69...

Powered by Google App Engine
This is Rietveld 408576698