[tools] Introduce gm.py

[tools] Introduce gm.py

Convenience wrapper around building with gn/ninja and running tests.
Follows Makefile syntax, but is more flexible; see --help.
Pro tip: alias gm="tools/dev/gm.py"

NOTRY=true

Review-Url: https://codereview.chromium.org/2713663002
Cr-Commit-Position: refs/heads/master@{#43377}
Committed: https://chromium.googlesource.com/v8/v8/+/b008f27f0271243e40dc1fc29d7b338136c63c0c

[Camillo Bruni, 2017-02-22 14:38:55]

cbruni@chromium.org changed reviewers:
+ cbruni@chromium.org

[Camillo Bruni, 2017-02-22 14:38:56]

LGTM with nits

https://codereview.chromium.org/2713663002/diff/1/tools/dev/gm.py
File tools/dev/gm.py (right):

https://codereview.chromium.org/2713663002/diff/1/tools/dev/gm.py#newcode68
tools/dev/gm.py:68: TESTSUITES = {"benchmarks": "d8",
nit: TESTSUITES_TARGETS

https://codereview.chromium.org/2713663002/diff/1/tools/dev/gm.py#newcode136
tools/dev/gm.py:136: if not silent: print("# %s" % cmd)
nit: I want it yellow, so I can distinguish the command from the output

https://codereview.chromium.org/2713663002/diff/1/tools/dev/gm.py#newcode186
tools/dev/gm.py:186: targets = " ".join([t for t in self.targets])
nit: " ".join(self.targets)

https://codereview.chromium.org/2713663002/diff/1/tools/dev/gm.py#newcode197
tools/dev/gm.py:197: tests = " ".join([t for t in self.tests])
nit: " ".join(self.tests)

[Jakob Kummerow, 2017-02-22 15:06:46]

Thanks, landing.

https://codereview.chromium.org/2713663002/diff/1/tools/dev/gm.py
File tools/dev/gm.py (right):

https://codereview.chromium.org/2713663002/diff/1/tools/dev/gm.py#newcode68
tools/dev/gm.py:68: TESTSUITES = {"benchmarks": "d8",
On 2017/02/22 14:38:56, Camillo Bruni wrote:
> nit: TESTSUITES_TARGETS

Done.

https://codereview.chromium.org/2713663002/diff/1/tools/dev/gm.py#newcode136
tools/dev/gm.py:136: if not silent: print("# %s" % cmd)
On 2017/02/22 14:38:56, Camillo Bruni wrote:
> nit: I want it yellow, so I can distinguish the command from the output

We accept patches :-P

https://codereview.chromium.org/2713663002/diff/1/tools/dev/gm.py#newcode186
tools/dev/gm.py:186: targets = " ".join([t for t in self.targets])
On 2017/02/22 14:38:56, Camillo Bruni wrote:
> nit: " ".join(self.targets)

Done.

https://codereview.chromium.org/2713663002/diff/1/tools/dev/gm.py#newcode197
tools/dev/gm.py:197: tests = " ".join([t for t in self.tests])
On 2017/02/22 14:38:56, Camillo Bruni wrote:
> nit: " ".join(self.tests)

Done.

[Jakob Kummerow, 2017-02-22 15:06:56]

Description was changed from

==========
[tools] Introduce gm.py

Convenience wrapper around building with gn/ninja and running tests.
Follows Makefile syntax, but is more flexible; see --help.
Pro tip: alias gm="tools/dev/gm.py"
==========

to

==========
[tools] Introduce gm.py

Convenience wrapper around building with gn/ninja and running tests.
Follows Makefile syntax, but is more flexible; see --help.
Pro tip: alias gm="tools/dev/gm.py"

NOTRY=true
==========

[Jakob Kummerow, 2017-02-22 15:07:06]

The CQ bit was checked by jkummerow@chromium.org

[Jakob Kummerow, 2017-02-22 15:07:07]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org
Link to the patchset: https://codereview.chromium.org/2713663002/#ps40001
(title: "refactored")

[commit-bot: I haz the power, 2017-02-22 15:07:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 15:09:29]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487776026898150,
"parent_rev": "beb94c5e874706734732851bc9f4ae177c553b6b", "commit_rev":
"b008f27f0271243e40dc1fc29d7b338136c63c0c"}

[commit-bot: I haz the power, 2017-02-22 15:09:33]

Description was changed from

==========
[tools] Introduce gm.py

Convenience wrapper around building with gn/ninja and running tests.
Follows Makefile syntax, but is more flexible; see --help.
Pro tip: alias gm="tools/dev/gm.py"

NOTRY=true
==========

to

==========
[tools] Introduce gm.py

Convenience wrapper around building with gn/ninja and running tests.
Follows Makefile syntax, but is more flexible; see --help.
Pro tip: alias gm="tools/dev/gm.py"

NOTRY=true

Review-Url: https://codereview.chromium.org/2713663002
Cr-Commit-Position: refs/heads/master@{#43377}
Committed:
https://chromium.googlesource.com/v8/v8/+/b008f27f0271243e40dc1fc29d7b338136c...
==========

[commit-bot: I haz the power, 2017-02-22 15:09:34]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/b008f27f0271243e40dc1fc29d7b338136c...