Remove fullscreen applist

Remove fullscreen applist

This was added 3 years ago as an experiment, but it's broken and causing crash. It's time to clean up.

BUG=664008
Review-Url: https://codereview.chromium.org/2713603002
Cr-Commit-Position: refs/heads/master@{#453496}
Committed: https://chromium.googlesource.com/chromium/src/+/f55eeecd02288e793a19b1f8fab177f3a9925ddb

[oshima, 2017-02-22 08:58:41]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 08:59:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 09:16:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 09:16:05]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oshima, 2017-02-22 23:40:16]

Patchset #2 (id:20001) has been deleted

[oshima, 2017-02-22 23:40:20]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 23:41:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 00:11:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 00:11:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oshima, 2017-02-23 02:24:29]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 02:25:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 03:55:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 03:55:13]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oshima, 2017-02-23 05:48:37]

Patchset #3 (id:60001) has been deleted

[oshima, 2017-02-23 05:48:41]

Patchset #2 (id:40001) has been deleted

[oshima, 2017-02-23 05:48:45]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[oshima, 2017-02-23 05:48:49]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-02-23 05:49:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oshima, 2017-02-23 06:41:24]

Description was changed from

==========
Remove fullscreen applist

BUG=664008
==========

to

==========
Remove fullscreen applist

BUG=664008
==========

[oshima, 2017-02-23 06:41:25]

oshima@chromium.org changed reviewers:
+ afakhry@chromium.org, asvitkine@chromium.org, jennyz@chromium.org

[oshima, 2017-02-23 06:42:23]

jennyz -> ui/app_list
asvitkine@ -> histograms.xml
afakhry@ -> rest

[oshima, 2017-02-23 06:43:23]

Description was changed from

==========
Remove fullscreen applist

BUG=664008
==========

to

==========
Remove fullscreen applist

This was added 3 years ago as an experiment, but it's broken and acusing crash.
It's time to clean up.

BUG=664008
==========

[commit-bot: I haz the power, 2017-02-23 06:50:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 06:50:28]

Dry run: This issue passed the CQ dry run.

[afakhry, 2017-02-23 18:27:36]

lgtm. Thanks for the cleanup!

https://codereview.chromium.org/2713603002/diff/80001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2713603002/diff/80001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:97319: -  <int value="-589096918"
label="ash-enable-fullscreen-app-list"/>
I think this shouldn't be removed even though the flag was removed.

[Alexei Svitkine (slow), 2017-02-23 18:43:46]

https://codereview.chromium.org/2713603002/diff/80001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2713603002/diff/80001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:97319: -  <int value="-589096918"
label="ash-enable-fullscreen-app-list"/>
On 2017/02/23 18:27:35, afakhry wrote:
> I think this shouldn't be removed even though the flag was removed.

Yep, it should be kept since it's used for decoding data from old versions.

[oshima, 2017-02-23 23:42:16]

oshima@chromium.org changed reviewers:
- asvitkine@chromium.org

[oshima, 2017-02-23 23:42:17]

thanks, removed the xml file.

[oshima, 2017-02-23 23:51:33]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 23:52:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oshima, 2017-02-24 01:32:56]

oshima@chromium.org changed reviewers:
+ benwells@chromium.org

[oshima, 2017-02-24 01:33:53]

+benwells@ who is in apac timezone

[oshima, 2017-02-24 01:34:12]

On 2017/02/24 01:33:53, oshima wrote:
> +benwells@ who is in apac timezone

for ui/app_list

[commit-bot: I haz the power, 2017-02-24 02:59:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 02:59:34]

Dry run: This issue passed the CQ dry run.

[benwells, 2017-02-24 03:26:56]

benwells@chromium.org changed reviewers:
+ calamity@chromium.org

[benwells, 2017-02-24 03:26:56]

punting to calamity

[calamity, 2017-02-24 03:32:45]

Description was changed from

==========
Remove fullscreen applist

This was added 3 years ago as an experiment, but it's broken and acusing crash.
It's time to clean up.

BUG=664008
==========

to

==========
Remove fullscreen applist

This was added 3 years ago as an experiment, but it's broken and causing crash.
It's time to clean up.

BUG=664008
==========

[oshima, 2017-02-28 01:54:08]

ping?

This is just removal of deprecated feature.

[calamity, 2017-02-28 02:16:20]

On 2017/02/28 01:54:08, oshima wrote:
> ping?
> 
> This is just removal of deprecated feature.

Sorry, looking now.

[calamity, 2017-02-28 02:35:02]

lgtm

[oshima, 2017-02-28 02:45:37]

The CQ bit was checked by oshima@chromium.org

[oshima, 2017-02-28 02:45:38]

The patchset sent to the CQ was uploaded after l-g-t-m from afakhry@chromium.org
Link to the patchset: https://codereview.chromium.org/2713603002/#ps100001
(title: ".")

[commit-bot: I haz the power, 2017-02-28 02:46:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 04:37:42]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1488249937725470,
"parent_rev": "a064e51b3f526c950dc03b4ccfe678202e922ad1", "commit_rev":
"f55eeecd02288e793a19b1f8fab177f3a9925ddb"}

[commit-bot: I haz the power, 2017-02-28 04:38:43]

Description was changed from

==========
Remove fullscreen applist

This was added 3 years ago as an experiment, but it's broken and causing crash.
It's time to clean up.

BUG=664008
==========

to

==========
Remove fullscreen applist

This was added 3 years ago as an experiment, but it's broken and causing crash.
It's time to clean up.

BUG=664008

Review-Url: https://codereview.chromium.org/2713603002
Cr-Commit-Position: refs/heads/master@{#453496}
Committed:
https://chromium.googlesource.com/chromium/src/+/f55eeecd02288e793a19b1f8fab1...
==========

[commit-bot: I haz the power, 2017-02-28 04:38:44]

Committed patchset #2 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/f55eeecd02288e793a19b1f8fab1...