Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 2713603002: Remove fullscreen applist (Closed)

Created:
3 years, 10 months ago by oshima
Modified:
3 years, 9 months ago
CC:
chromium-reviews, kalyank, sadrul, asvitkine+watch_chromium.org, Alexei Svitkine (slow), benwells
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove fullscreen applist This was added 3 years ago as an experiment, but it's broken and causing crash. It's time to clean up. BUG=664008 Review-Url: https://codereview.chromium.org/2713603002 Cr-Commit-Position: refs/heads/master@{#453496} Committed: https://chromium.googlesource.com/chromium/src/+/f55eeecd02288e793a19b1f8fab177f3a9925ddb

Patch Set 1 : . #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -76 lines) Patch
M ash/app_list/app_list_presenter_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/app_list/app_list_presenter_delegate.cc View 3 chunks +4 lines, -35 lines 0 comments Download
M ash/common/ash_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/ash_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/app/chromeos_strings.grdp View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/app_list/presenter/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/app_list/presenter/app_list_presenter_impl_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ui/app_list/views/app_list_view.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/app_list/views/app_list_view.cc View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 47 (35 generated)
oshima
jennyz -> ui/app_list asvitkine@ -> histograms.xml afakhry@ -> rest
3 years, 10 months ago (2017-02-23 06:42:23 UTC) #21
afakhry
lgtm. Thanks for the cleanup! https://codereview.chromium.org/2713603002/diff/80001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/2713603002/diff/80001/tools/metrics/histograms/histograms.xml#oldcode97319 tools/metrics/histograms/histograms.xml:97319: - <int value="-589096918" label="ash-enable-fullscreen-app-list"/> ...
3 years, 10 months ago (2017-02-23 18:27:36 UTC) #25
Alexei Svitkine (slow)
https://codereview.chromium.org/2713603002/diff/80001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/2713603002/diff/80001/tools/metrics/histograms/histograms.xml#oldcode97319 tools/metrics/histograms/histograms.xml:97319: - <int value="-589096918" label="ash-enable-fullscreen-app-list"/> On 2017/02/23 18:27:35, afakhry wrote: ...
3 years, 10 months ago (2017-02-23 18:43:46 UTC) #26
oshima
thanks, removed the xml file.
3 years, 10 months ago (2017-02-23 23:42:17 UTC) #28
oshima
+benwells@ who is in apac timezone
3 years, 10 months ago (2017-02-24 01:33:53 UTC) #32
oshima
On 2017/02/24 01:33:53, oshima wrote: > +benwells@ who is in apac timezone for ui/app_list
3 years, 10 months ago (2017-02-24 01:34:12 UTC) #33
benwells
punting to calamity
3 years, 10 months ago (2017-02-24 03:26:56 UTC) #37
oshima
ping? This is just removal of deprecated feature.
3 years, 9 months ago (2017-02-28 01:54:08 UTC) #39
calamity
On 2017/02/28 01:54:08, oshima wrote: > ping? > > This is just removal of deprecated ...
3 years, 9 months ago (2017-02-28 02:16:20 UTC) #40
calamity
lgtm
3 years, 9 months ago (2017-02-28 02:35:02 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2713603002/100001
3 years, 9 months ago (2017-02-28 02:46:31 UTC) #44
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 04:38:44 UTC) #47
Message was sent while issue was closed.
Committed patchset #2 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/f55eeecd02288e793a19b1f8fab1...

Powered by Google App Engine
This is Rietveld 408576698