Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2713593003: Address some TODOs at frame_connected_bluetooth_devices.cc (Closed)

Created:
3 years, 10 months ago by juncai
Modified:
3 years, 10 months ago
Reviewers:
ortuno
CC:
chromium-reviews, darin-cc_chromium.org, jam, ortuno+watch_chromium.org, scheib+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Address some TODOs at frame_connected_bluetooth_devices.cc This CL addresses some TODOs at frame_connected_bluetooth_devices.cc. BUG=607273 Review-Url: https://codereview.chromium.org/2713593003 Cr-Commit-Position: refs/heads/master@{#452395} Committed: https://chromium.googlesource.com/chromium/src/+/21d696fad037bef366dc0a3a205f6da0669ce2b4

Patch Set 1 : address some TODOs at frame_connected_bluetooth_devices.cc #

Total comments: 2

Patch Set 2 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -34 lines) Patch
M content/browser/bluetooth/frame_connected_bluetooth_devices.cc View 1 1 chunk +14 lines, -34 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
juncai
Please take a look.
3 years, 10 months ago (2017-02-23 01:14:19 UTC) #4
ortuno
Thanks for the clean up! lgtm https://codereview.chromium.org/2713593003/diff/1/content/browser/bluetooth/frame_connected_bluetooth_devices.cc File content/browser/bluetooth/frame_connected_bluetooth_devices.cc (right): https://codereview.chromium.org/2713593003/diff/1/content/browser/bluetooth/frame_connected_bluetooth_devices.cc#newcode32 content/browser/bluetooth/frame_connected_bluetooth_devices.cc:32: return true; nit: ...
3 years, 10 months ago (2017-02-23 02:27:03 UTC) #5
juncai
https://codereview.chromium.org/2713593003/diff/1/content/browser/bluetooth/frame_connected_bluetooth_devices.cc File content/browser/bluetooth/frame_connected_bluetooth_devices.cc (right): https://codereview.chromium.org/2713593003/diff/1/content/browser/bluetooth/frame_connected_bluetooth_devices.cc#newcode32 content/browser/bluetooth/frame_connected_bluetooth_devices.cc:32: return true; On 2017/02/23 02:27:03, ortuno wrote: > nit: ...
3 years, 10 months ago (2017-02-23 04:53:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2713593003/20001
3 years, 10 months ago (2017-02-23 04:54:09 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 05:00:00 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/21d696fad037bef366dc0a3a205f...

Powered by Google App Engine
This is Rietveld 408576698