third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py - Issue 2713553010: Migrate performance monitor to inspector instrumentation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py

Issue 2713553010: Migrate performance monitor to inspector instrumentation. (Closed)

Patch Set: Introduce progress monitor Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/PerformanceMonitorTest.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py

diff --git a/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py b/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py

index 7b676e637d775e4ce71f15eca9a4b1d0de4879f5..4681af3091dbe8b003a990ba477606f4f246e62e 100755

--- a/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py

+++ b/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py

@@ -350,6 +350,8 @@ def generate_param_name(param_type):

def agent_class_name(agent):

+ if agent == "Performance":

+ return "PerformanceMonitor"

alph 2017/02/24 23:05:53 Let's rename it instead?

pfeldman 2017/02/24 23:53:11 We need to make codegen more flexible.

return "Inspector%sAgent" % agent

@@ -363,6 +365,8 @@ def include_header(name):

def include_inspector_header(name):

+ if name == "PerformanceMonitor":

+ return include_header("core/frame/" + name)

return include_header("core/inspector/" + name)