Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 2713553010: Migrate performance monitor to inspector instrumentation. (Closed)

Created:
3 years, 10 months ago by pfeldman
Modified:
3 years, 9 months ago
Reviewers:
caseq, alph
CC:
chromium-reviews, caseq+blink_chromium.org, pfeldman+blink_chromium.org, sof, eae+blinkwatch, Yoav Weiss, lushnikov+blink_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, blink-reviews, apavlov+blink_chromium.org, kozyatinskiy+blink_chromium.org, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate performance monitor to inspector instrumentation. BUG=695625 Review-Url: https://codereview.chromium.org/2713553010 Cr-Commit-Position: refs/heads/master@{#453517} Committed: https://chromium.googlesource.com/chromium/src/+/fc9533e11917bced54ea40a842d9b0333bc85b09

Patch Set 1 #

Patch Set 2 : always instrument everything always* #

Patch Set 3 : Introduce progress monitor #

Total comments: 2

Patch Set 4 : Introduce progress monitor #

Patch Set 5 : Introduce progress monitor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -115 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 2 3 4 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 2 3 4 3 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/PerformanceMonitor.h View 1 2 3 4 3 chunks +11 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp View 1 2 3 4 8 chunks +31 lines, -82 lines 0 comments Download
M third_party/WebKit/Source/core/frame/PerformanceMonitorTest.cpp View 1 2 3 3 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl View 3 chunks +21 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 31 (24 generated)
pfeldman
3 years, 10 months ago (2017-02-23 23:55:08 UTC) #2
alph
lgtm https://codereview.chromium.org/2713553010/diff/40001/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py File third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py (right): https://codereview.chromium.org/2713553010/diff/40001/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py#newcode354 third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py:354: return "PerformanceMonitor" Let's rename it instead?
3 years, 10 months ago (2017-02-24 23:05:53 UTC) #13
pfeldman
https://codereview.chromium.org/2713553010/diff/40001/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py File third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py (right): https://codereview.chromium.org/2713553010/diff/40001/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py#newcode354 third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py:354: return "PerformanceMonitor" We need to make codegen more flexible.
3 years, 10 months ago (2017-02-24 23:53:11 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2713553010/60001
3 years, 10 months ago (2017-02-25 02:03:54 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/397837)
3 years, 10 months ago (2017-02-25 03:17:20 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2713553010/80001
3 years, 9 months ago (2017-02-28 06:05:15 UTC) #28
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 06:11:28 UTC) #31
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/fc9533e11917bced54ea40a842d9...

Powered by Google App Engine
This is Rietveld 408576698