Add PRESUBMIT to make sure that perf JSON configs are always up-to-date

Add PRESUBMIT to make sure that perf JSON configs are always up-to-date

BUG=695162
Review-Url: https://codereview.chromium.org/2713553008
Cr-Commit-Position: refs/heads/master@{#452573}
Committed: https://chromium.googlesource.com/chromium/src/+/292aea8a39a41d3d01cf754680d814ebc0d72b30

[nednguyen, 2017-02-23 15:40:25]

nednguyen@google.com changed reviewers:
+ charliea@chromium.org, martiniss@chromium.org, rnephew@chromium.org

[nednguyen, 2017-02-23 15:40:31]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[nednguyen, 2017-02-23 15:40:50]

On 2017/02/23 15:40:26, nednguyen wrote:

Note: this is not landadble until https://codereview.chromium.org/2708373003/ is
fixed.

[commit-bot: I haz the power, 2017-02-23 15:40:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 15:48:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 15:48:19]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[rnephew (Reviews Here), 2017-02-23 15:49:09]

lgtm with nits.

https://codereview.chromium.org/2713553008/diff/1/tools/perf/PRESUBMIT.py
File tools/perf/PRESUBMIT.py (right):

https://codereview.chromium.org/2713553008/diff/1/tools/perf/PRESUBMIT.py#new...
tools/perf/PRESUBMIT.py:52: out, return_code =  _RunArgs([
nit: only need 1 space here.

https://codereview.chromium.org/2713553008/diff/1/tools/perf/PRESUBMIT.py#new...
tools/perf/PRESUBMIT.py:53: input_api.python_executable,
Nit:Seems like too many spaces.

https://codereview.chromium.org/2713553008/diff/1/tools/perf/PRESUBMIT.py#new...
tools/perf/PRESUBMIT.py:58: 'Validating Perf JSON configs failed.',
long_text=out))
Nit:Seems like too many spaces.

[nednguyen, 2017-02-23 17:49:13]

https://codereview.chromium.org/2713553008/diff/1/tools/perf/PRESUBMIT.py
File tools/perf/PRESUBMIT.py (right):

https://codereview.chromium.org/2713553008/diff/1/tools/perf/PRESUBMIT.py#new...
tools/perf/PRESUBMIT.py:52: out, return_code =  _RunArgs([
On 2017/02/23 15:49:08, rnephew (Reviews Here) wrote:
> nit: only need 1 space here.

Done.

https://codereview.chromium.org/2713553008/diff/1/tools/perf/PRESUBMIT.py#new...
tools/perf/PRESUBMIT.py:53: input_api.python_executable,
On 2017/02/23 15:49:08, rnephew (Reviews Here) wrote:
> Nit:Seems like too many spaces.

Done.

https://codereview.chromium.org/2713553008/diff/1/tools/perf/PRESUBMIT.py#new...
tools/perf/PRESUBMIT.py:58: 'Validating Perf JSON configs failed.',
long_text=out))
On 2017/02/23 15:49:09, rnephew (Reviews Here) wrote:
> Nit:Seems like too many spaces.

Done.

[nednguyen, 2017-02-23 17:51:37]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2017-02-23 17:51:38]

The patchset sent to the CQ was uploaded after l-g-t-m from rnephew@chromium.org
Link to the patchset: https://codereview.chromium.org/2713553008/#ps20001
(title: "Address Randy's nits")

[commit-bot: I haz the power, 2017-02-23 17:52:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 19:06:04]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487872297861220,
"parent_rev": "b68c766fd39bb96d5603421789b9febbc97b9a47", "commit_rev":
"292aea8a39a41d3d01cf754680d814ebc0d72b30"}

[commit-bot: I haz the power, 2017-02-23 19:07:02]

Description was changed from

==========
Add PRESUBMIT to make sure that perf JSON configs are always up-to-date

BUG=695162
==========

to

==========
Add PRESUBMIT to make sure that perf JSON configs are always up-to-date

BUG=695162

Review-Url: https://codereview.chromium.org/2713553008
Cr-Commit-Position: refs/heads/master@{#452573}
Committed:
https://chromium.googlesource.com/chromium/src/+/292aea8a39a41d3d01cf754680d8...
==========

[commit-bot: I haz the power, 2017-02-23 19:07:03]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/292aea8a39a41d3d01cf754680d8...