Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 2713553004: MD Settings: Manage a11y page, clear search param when navigating. (Closed)

Created:
3 years, 10 months ago by dpapad
Modified:
3 years, 10 months ago
Reviewers:
stevenjb
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Manage a11y page, clear search param when navigating. Navigating to a different page requires clearing the search parameter, so that the page exits search mode. This is identical with what the settings-menu does when navigating while in search mode. BUG=690620 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2713553004 Cr-Commit-Position: refs/heads/master@{#452307} Committed: https://chromium.googlesource.com/chromium/src/+/e1a5f4de7e19dd33e3781609dd325fa715f354d2

Patch Set 1 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M chrome/browser/resources/settings/a11y_page/manage_a11y_page.js View 1 chunk +12 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
dpapad
3 years, 10 months ago (2017-02-22 22:58:41 UTC) #8
stevenjb
nit: Could use a helper to simplify the code a bit, but lgtm as-is.
3 years, 10 months ago (2017-02-22 23:00:25 UTC) #9
dpapad
On 2017/02/22 at 23:00:25, stevenjb wrote: > nit: Could use a helper to simplify the ...
3 years, 10 months ago (2017-02-23 00:05:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2713553004/20001
3 years, 10 months ago (2017-02-23 00:06:03 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 00:38:49 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e1a5f4de7e19dd33e3781609dd32...

Powered by Google App Engine
This is Rietveld 408576698