Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2713553003: Convert SpinButtonElement timer to UnspecedTimer frame-specific timer. (Closed)

Created:
3 years, 10 months ago by joelhockey
Modified:
3 years, 10 months ago
Reviewers:
haraken, slangley
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert SpinButtonElement timer to UnspecedTimer frame-specific timer. SpinButtonElement is an internal implementation of Button UI and is not covered by the spec. BUG=624694 Review-Url: https://codereview.chromium.org/2713553003 Cr-Commit-Position: refs/heads/master@{#452750} Committed: https://chromium.googlesource.com/chromium/src/+/3203af1cc27fd76dd3ff9e129c385d6176a505c0

Patch Set 1 #

Patch Set 2 : Convert SpinButtonElement timer to UnspecedTimer frame-specific timer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M third_party/WebKit/Source/core/html/shadow/SpinButtonElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/shadow/SpinButtonElement.cpp View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
joelhockey
3 years, 10 months ago (2017-02-22 10:51:09 UTC) #3
haraken
IIUC, this is not a speced task -- the spin button is just an internal ...
3 years, 10 months ago (2017-02-22 23:52:19 UTC) #5
joelhockey
On 2017/02/22 at 23:52:19, haraken wrote: > IIUC, this is not a speced task -- ...
3 years, 10 months ago (2017-02-24 01:59:22 UTC) #7
haraken
LGTM
3 years, 10 months ago (2017-02-24 02:26:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2713553003/20001
3 years, 10 months ago (2017-02-24 03:06:33 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 04:28:28 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3203af1cc27fd76dd3ff9e129c38...

Powered by Google App Engine
This is Rietveld 408576698