service worker: Add console.warn output to enable -expected.txt files

service worker: Add console.warn output to enable -expected.txt files

These tests dump output via console.log in order to have different
-expected.txt files for different virtual tests, but the presubmit wants
to remove -expected.txt files with no assertions. According to the
thread "[blink-dev] PSA/Proposal: Changing the definition of "passing"
for layout tests that use testharness.js"[1] we can add console.warn to get
around this. Long-term we should migrate the tests to use assertions or
not use testharness.js.

[1] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/3Ob2lq14KEs

BUG=649558
Review-Url: https://codereview.chromium.org/2713523004
Cr-Commit-Position: refs/heads/master@{#451897}
Committed: https://chromium.googlesource.com/chromium/src/+/a994e58847b6e37d0e1a3067509653ec314d137a

[falken, 2017-02-22 01:57:16]

Description was changed from

==========
service worker: Add console.warn output to enable -expected.txt files

These tests dump output via console.log in order to have different
-expected.txt files for different virtual tests, but the presubmit wants
to remove -expected.txt files with no assertions. According to the
blink-dev thread we can add console.warn to get around this. Long-term
we should migrate the tests to use assertions or not use testharness.js.

BUG=649558
==========

to

==========
service worker: Add console.warn output to enable -expected.txt files

These tests dump output via console.log in order to have different
-expected.txt files for different virtual tests, but the presubmit wants
to remove -expected.txt files with no assertions. According to the
thread "[blink-dev] PSA/Proposal: Changing the definition of "passing"
for layout tests that use testharness.js" we can add console.warn to get
around this. Long-term we should migrate the tests to use assertions or
not use testharness.js.

BUG=649558
==========

[falken, 2017-02-22 01:57:56]

falken@chromium.org changed reviewers:
+ delphick@chromium.org, horo@chromium.org

[falken, 2017-02-22 03:36:55]

The CQ bit was checked by falken@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 03:37:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[horo, 2017-02-22 04:59:12]

lgtm

Please write this link in the CL description.
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/3Ob2lq14KEs

[falken, 2017-02-22 05:04:02]

Description was changed from

==========
service worker: Add console.warn output to enable -expected.txt files

These tests dump output via console.log in order to have different
-expected.txt files for different virtual tests, but the presubmit wants
to remove -expected.txt files with no assertions. According to the
thread "[blink-dev] PSA/Proposal: Changing the definition of "passing"
for layout tests that use testharness.js" we can add console.warn to get
around this. Long-term we should migrate the tests to use assertions or
not use testharness.js.

BUG=649558
==========

to

==========
service worker: Add console.warn output to enable -expected.txt files

These tests dump output via console.log in order to have different
-expected.txt files for different virtual tests, but the presubmit wants
to remove -expected.txt files with no assertions. According to the
thread "[blink-dev] PSA/Proposal: Changing the definition of "passing"
for layout tests that use testharness.js"[1] we can add console.warn to get
around this. Long-term we should migrate the tests to use assertions or
not use testharness.js.

[1] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/3Ob2lq14KEs

BUG=649558
==========

[falken, 2017-02-22 05:04:23]

Thanks, done.

[falken, 2017-02-22 05:04:49]

The CQ bit was unchecked by falken@chromium.org

[falken, 2017-02-22 05:04:53]

The CQ bit was checked by falken@chromium.org

[commit-bot: I haz the power, 2017-02-22 05:05:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 06:18:38]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487739893788240, "parent_rev":
"2a2916002bb2029b159fb35a060edb48e064df14", "commit_rev":
"a994e58847b6e37d0e1a3067509653ec314d137a"}

[commit-bot: I haz the power, 2017-02-22 06:19:40]

Description was changed from

==========
service worker: Add console.warn output to enable -expected.txt files

These tests dump output via console.log in order to have different
-expected.txt files for different virtual tests, but the presubmit wants
to remove -expected.txt files with no assertions. According to the
thread "[blink-dev] PSA/Proposal: Changing the definition of "passing"
for layout tests that use testharness.js"[1] we can add console.warn to get
around this. Long-term we should migrate the tests to use assertions or
not use testharness.js.

[1] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/3Ob2lq14KEs

BUG=649558
==========

to

==========
service worker: Add console.warn output to enable -expected.txt files

These tests dump output via console.log in order to have different
-expected.txt files for different virtual tests, but the presubmit wants
to remove -expected.txt files with no assertions. According to the
thread "[blink-dev] PSA/Proposal: Changing the definition of "passing"
for layout tests that use testharness.js"[1] we can add console.warn to get
around this. Long-term we should migrate the tests to use assertions or
not use testharness.js.

[1] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/3Ob2lq14KEs

BUG=649558

Review-Url: https://codereview.chromium.org/2713523004
Cr-Commit-Position: refs/heads/master@{#451897}
Committed:
https://chromium.googlesource.com/chromium/src/+/a994e58847b6e37d0e1a30675096...
==========

[commit-bot: I haz the power, 2017-02-22 06:19:41]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a994e58847b6e37d0e1a30675096...

[Dan Elphick, 2017-02-22 10:02:12]

lgtm