Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 2713483002: cc: Always report locked_size in software image cache. (Closed)

Created:
3 years, 10 months ago by vmpstr
Modified:
3 years, 10 months ago
Reviewers:
ericrk
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Always report locked_size in software image cache. This patch ensures that we always report the locked_size, and we report 0 if the decode is unlocked. R=ericrk@chromium.org BUG=693968 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2713483002 Cr-Commit-Position: refs/heads/master@{#452262} Committed: https://chromium.googlesource.com/chromium/src/+/7d1142a765ae5648b212d357e4db425e2fad3623

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M cc/tiles/gpu_image_decode_cache.cc View 1 1 chunk +5 lines, -6 lines 0 comments Download
M cc/tiles/software_image_decode_cache.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
vmpstr
Please take a look.
3 years, 10 months ago (2017-02-21 22:33:40 UTC) #2
ericrk
lgtm
3 years, 10 months ago (2017-02-21 23:52:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2713483002/1
3 years, 10 months ago (2017-02-22 00:14:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
3 years, 10 months ago (2017-02-22 02:18:02 UTC) #7
ericrk
Just realized, can you update the similar code in gpu_idc.cc (search for locked_size)? Thanks!
3 years, 10 months ago (2017-02-22 03:42:45 UTC) #8
vmpstr
On 2017/02/22 03:42:45, ericrk wrote: > Just realized, can you update the similar code in ...
3 years, 10 months ago (2017-02-22 22:01:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2713483002/20001
3 years, 10 months ago (2017-02-22 22:03:03 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 23:18:58 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7d1142a765ae5648b212d357e4db...

Powered by Google App Engine
This is Rietveld 408576698