[Android Crash Reporting] Componentize MinidumpUploader.java

[Android Crash Reporting] Componentize MinidumpUploader.java

BUG=694884
TEST=compile
R=gsennton@chromium.org

Review-Url: https://codereview.chromium.org/2713473003
Cr-Commit-Position: refs/heads/master@{#452440}
Committed: https://chromium.googlesource.com/chromium/src/+/85fe2a8ce1f31d30a8aa7417472aa9bd42c99f47

[Ilya Sherman, 2017-02-22 02:42:16]

isherman@chromium.org changed reviewers:
+ tobiasjs@chromium.org

[Ilya Sherman, 2017-02-22 02:42:16]

+Tobias for OWNERS approval

[gsennton, 2017-02-22 08:53:07]

You'll need to change the import in 
android_webview/javatests/src/org/chromium/android_webview/test/crash/MinidumpUploaderTest.java
as well.

If you ever need to run those tests:

ninja -C out/Debug -j150 -l30 android_webview_apk android_webview_test_apk

out/Debug/bin/run_android_webview_test_apk -f MinidumpUploaderTest#*

apart from that, lgtm

[Tobias Sargeant, 2017-02-22 11:22:15]

On 2017/02/22 08:53:07, gsennton wrote:
> You'll need to change the import in 
>
android_webview/javatests/src/org/chromium/android_webview/test/crash/MinidumpUploaderTest.java
> as well.
> 
> If you ever need to run those tests:
> 
> ninja -C out/Debug -j150 -l30 android_webview_apk android_webview_test_apk
> 
> out/Debug/bin/run_android_webview_test_apk -f MinidumpUploaderTest#*
> 
> apart from that, lgtm

LGTM when the above is addressed.

[Ilya Sherman, 2017-02-23 08:17:55]

On 2017/02/22 08:53:07, gsennton wrote:
> You'll need to change the import in 
>
android_webview/javatests/src/org/chromium/android_webview/test/crash/MinidumpUploaderTest.java
> as well.
> 
> If you ever need to run those tests:
> 
> ninja -C out/Debug -j150 -l30 android_webview_apk android_webview_test_apk
> 
> out/Debug/bin/run_android_webview_test_apk -f MinidumpUploaderTest#*

Ah, good call!  I built the webview_apk, but forgot to also build the test apk. 
Thanks for the pointers!

[Ilya Sherman, 2017-02-23 08:18:02]

The CQ bit was checked by isherman@chromium.org

[Ilya Sherman, 2017-02-23 08:18:10]

The CQ bit was unchecked by isherman@chromium.org

[Ilya Sherman, 2017-02-23 08:18:38]

The CQ bit was checked by isherman@chromium.org

[Ilya Sherman, 2017-02-23 08:18:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
gsennton@chromium.org, tobiasjs@chromium.org
Link to the patchset: https://codereview.chromium.org/2713473003/#ps20001
(title: "Fix tests, too")

[commit-bot: I haz the power, 2017-02-23 08:18:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 09:21:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487837918691820,
"parent_rev": "e0a9ba6076a8522976835cafac5e389aab66a43e", "commit_rev":
"85fe2a8ce1f31d30a8aa7417472aa9bd42c99f47"}

[commit-bot: I haz the power, 2017-02-23 09:22:31]

Description was changed from

==========
[Android Crash Reporting] Componentize MinidumpUploader.java

BUG=694884
TEST=compile
R=gsennton@chromium.org
==========

to

==========
[Android Crash Reporting] Componentize MinidumpUploader.java

BUG=694884
TEST=compile
R=gsennton@chromium.org

Review-Url: https://codereview.chromium.org/2713473003
Cr-Commit-Position: refs/heads/master@{#452440}
Committed:
https://chromium.googlesource.com/chromium/src/+/85fe2a8ce1f31d30a8aa7417472a...
==========

[commit-bot: I haz the power, 2017-02-23 09:22:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/85fe2a8ce1f31d30a8aa7417472a...