Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2713433003: PPC/s390: [wasm] Use builtins wrappers for traps (Closed)

Created:
3 years, 10 months ago by JaideepBajwa
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [wasm] Use builtins wrappers for traps Port 73d45c9630f4e7561d5c6155cae97bb43dffaa54 Original Commit Message: With this CL the out-of-line code of TrapIf will call a builtin instead of doing a direct runtime call, which is cheaper. In the best case, the out-of-line code now consists of a single call instruction. The builtin will load the trapID and then call the runtime to throw a trap. R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2713433003 Cr-Commit-Position: refs/heads/master@{#43382} Committed: https://chromium.googlesource.com/v8/v8/+/f8158cdbdb58dfbf095581af386ceac7f7314af7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/compiler/s390/code-generator-s390.cc View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
JaideepBajwa
ptal
3 years, 10 months ago (2017-02-22 15:48:07 UTC) #1
john.yan
lgtm
3 years, 10 months ago (2017-02-22 16:03:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2713433003/1
3 years, 10 months ago (2017-02-22 16:05:26 UTC) #4
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 16:24:45 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/f8158cdbdb58dfbf095581af386ceac7f73...

Powered by Google App Engine
This is Rietveld 408576698