Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2713433002: remove unnecessary thread hopping when updating Download notifications (Closed)

Created:
3 years, 10 months ago by qinmin
Modified:
3 years, 10 months ago
Reviewers:
gone
CC:
chromium-reviews, asanka, agrieve+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

remove unnecessary thread hopping when updating Download notifications We create an async task to call DownloadManagerService.updateAllNotifications() when updating notifications. However, later we post a task back to the Ui thread in SystemDownloadNotifier We create the Async task just because of the strict mode: addCompletedDownload() and canResolveDownloadItem() needs to be on a non UI thread. This CL moves the updateAllNotifications() back to the UI thread. only addCompletedDownload() and canResolveDownloadItem() are left in the async task. BUG=693273 TBR=dfalcantara@chromium.org Review-Url: https://codereview.chromium.org/2701613005 Cr-Commit-Position: refs/heads/master@{#451524} (cherry picked from commit 5939cf034a8d276d3f08b16a85503905a4c0580a) Review-Url: https://codereview.chromium.org/2713433002 . Cr-Commit-Position: refs/branch-heads/2987@{#614} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/077bc6423f11464baa6e8c1a164e37f0f5239e6f

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
qinmin
3 years, 10 months ago (2017-02-21 19:06:22 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
077bc6423f11464baa6e8c1a164e37f0f5239e6f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698