Chromium Code Reviews
Descriptionremove unnecessary thread hopping when updating Download notifications
We create an async task to call DownloadManagerService.updateAllNotifications() when updating notifications.
However, later we post a task back to the Ui thread in SystemDownloadNotifier
We create the Async task just because of the strict mode:
addCompletedDownload() and canResolveDownloadItem() needs to be on a non UI thread.
This CL moves the updateAllNotifications() back to the UI thread.
only addCompletedDownload() and canResolveDownloadItem() are left in the async task.
BUG=693273
TBR=dfalcantara@chromium.org
Review-Url: https://codereview.chromium.org/2701613005
Cr-Commit-Position: refs/heads/master@{#451524}
(cherry picked from commit 5939cf034a8d276d3f08b16a85503905a4c0580a)
Review-Url: https://codereview.chromium.org/2713433002 .
Cr-Commit-Position: refs/branch-heads/2987@{#614}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed: https://chromium.googlesource.com/chromium/src/+/077bc6423f11464baa6e8c1a164e37f0f5239e6f
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||