Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2713383002:
Fix rebaseline bug when new files are under untracked directories (Closed)
DescriptionFix rebaseline bug when new files are under untracked directories
Previously when some new baseline files are under new directories,
Git.untracked_files() returned the untracked directories, without
the new baseline files, causing the new baseline files not added.
Add '--untracked-files=all' paramter to 'git status' command to
show untracked files under untracked directories.
BUG=676748
Review-Url: https://codereview.chromium.org/2713383002
Cr-Commit-Position: refs/heads/master@{#453260}
Committed: https://chromium.googlesource.com/chromium/src/+/fc6161dbf888519842e446982a6e0a86c7476df6
Patch Set 1 #Patch Set 2 : --untracked-files=all #Messages
Total messages: 17 (12 generated)
The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
wangxianzhu@chromium.org changed reviewers: + qyearsley@chromium.org, wkorman@chromium.org
Description was changed from ========== Fix rebaseline bug when new files are under untracked directories Previously when some new baseline filess are under new directories, Git.untracked_files() returned the untracked directories, without the new baseline files, causing the new baseline not added. Add '-uall' paramter to 'git status' command to show untracked files under untracked directories. BUG=621126 ========== to ========== Fix rebaseline bug when new files are under untracked directories Previously when some new baseline filess are under new directories, Git.untracked_files() returned the untracked directories, without the new baseline files, causing the new baseline not added. Add '-uall' paramter to 'git status' command to show untracked files under untracked directories. BUG=676748 ==========
Description was changed from ========== Fix rebaseline bug when new files are under untracked directories Previously when some new baseline filess are under new directories, Git.untracked_files() returned the untracked directories, without the new baseline files, causing the new baseline not added. Add '-uall' paramter to 'git status' command to show untracked files under untracked directories. BUG=676748 ========== to ========== Fix rebaseline bug when new files are under untracked directories Previously when some new baseline files are under new directories, Git.untracked_files() returned the untracked directories, without the new baseline files, causing the new baseline files not added. Add '-uall' paramter to 'git status' command to show untracked files under untracked directories. BUG=676748 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM, thank you! Optionally, this flag could also be given as --untracked-files=all, which may be a bit more readable. Although, I think a comment is helpful here anyway, and if there's a comment then -uall is fine too.
Description was changed from ========== Fix rebaseline bug when new files are under untracked directories Previously when some new baseline files are under new directories, Git.untracked_files() returned the untracked directories, without the new baseline files, causing the new baseline files not added. Add '-uall' paramter to 'git status' command to show untracked files under untracked directories. BUG=676748 ========== to ========== Fix rebaseline bug when new files are under untracked directories Previously when some new baseline files are under new directories, Git.untracked_files() returned the untracked directories, without the new baseline files, causing the new baseline files not added. Add '--untracked-files=all' paramter to 'git status' command to show untracked files under untracked directories. BUG=676748 ==========
On 2017/02/27 16:19:37, qyearsley wrote: > LGTM, thank you! > > Optionally, this flag could also be given as --untracked-files=all, which may be > a bit more readable. Although, I think a comment is helpful here anyway, and if > there's a comment then -uall is fine too. Done.
The CQ bit was checked by wangxianzhu@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from qyearsley@chromium.org Link to the patchset: https://codereview.chromium.org/2713383002/#ps20001 (title: "--untracked-files=all")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488214724149870,
"parent_rev": "9f058d69c1820c58ca8df07865b7021e5ba3030f", "commit_rev":
"fc6161dbf888519842e446982a6e0a86c7476df6"}
Message was sent while issue was closed.
Description was changed from ========== Fix rebaseline bug when new files are under untracked directories Previously when some new baseline files are under new directories, Git.untracked_files() returned the untracked directories, without the new baseline files, causing the new baseline files not added. Add '--untracked-files=all' paramter to 'git status' command to show untracked files under untracked directories. BUG=676748 ========== to ========== Fix rebaseline bug when new files are under untracked directories Previously when some new baseline files are under new directories, Git.untracked_files() returned the untracked directories, without the new baseline files, causing the new baseline files not added. Add '--untracked-files=all' paramter to 'git status' command to show untracked files under untracked directories. BUG=676748 Review-Url: https://codereview.chromium.org/2713383002 Cr-Commit-Position: refs/heads/master@{#453260} Committed: https://chromium.googlesource.com/chromium/src/+/fc6161dbf888519842e446982a6e... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/fc6161dbf888519842e446982a6e... |
