Chromium Code Reviews
Help | Chromium Project | Sign in
(6)

Issue 2713373002: Fix 'auto variable type must not deduce to a raw pointer type' errors in Ozone/Wayland code (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 weeks, 6 days ago by tonikitoo
Modified:
3 weeks, 6 days ago
Reviewers:
rjkroege, spang
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org, fwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix 'auto variable type must not deduce to a raw pointer type' errors in Ozone/Wayland code As per [1], linux builds will check whether not using auto to deduce a raw pointer. Errors like below have been caught by the 'linux_chromium_ozone_compile_only_ng' FYI buildbot, which builds the Ozone/Wayland code. error: [chromium-style] auto variable type must not deduce to a raw pointer type. [1] https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/PMxDx7eR_YY BUG=None TBR=rjkroege@chromium.org,spang@chromium.org Review-Url: https://codereview.chromium.org/2713373002 Cr-Commit-Position: refs/heads/master@{#453072} Committed: https://chromium.googlesource.com/chromium/src/+/f24d368485ec3733bb77c65de4c0637f4a19c4e6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M ui/ozone/demo/ozone_demo.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/wayland/fake_server.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M ui/ozone/platform/wayland/wayland_keyboard_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/wayland/wayland_pointer_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M ui/ozone/platform/wayland/wayland_window_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 7 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2713373002/1
3 weeks, 6 days ago (2017-02-25 04:51:03 UTC) #4
commit-bot: I haz the power
3 weeks, 6 days ago (2017-02-25 05:18:03 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f24d368485ec3733bb77c65de4c0...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d1a128a62