Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline/EventsTimelineTreeView.js

Issue 2713363002: DevTools: Highlight DOM node on hover in flamechart. (Closed)
Patch Set: fix tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @unrestricted 6 * @unrestricted
7 */ 7 */
8 Timeline.EventsTimelineTreeView = class extends Timeline.TimelineTreeView { 8 Timeline.EventsTimelineTreeView = class extends Timeline.TimelineTreeView {
9 /** 9 /**
10 * @param {!Array<!TimelineModel.TimelineModelFilter>} filters 10 * @param {!Array<!TimelineModel.TimelineModelFilter>} filters
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 106
107 /** 107 /**
108 * @override 108 * @override
109 * @param {!TimelineModel.TimelineProfileTree.Node} node 109 * @param {!TimelineModel.TimelineProfileTree.Node} node
110 * @return {boolean} 110 * @return {boolean}
111 */ 111 */
112 _showDetailsForNode(node) { 112 _showDetailsForNode(node) {
113 var traceEvent = node.event; 113 var traceEvent = node.event;
114 if (!traceEvent) 114 if (!traceEvent)
115 return false; 115 return false;
116 Timeline.TimelineUIUtils.buildTraceEventDetails( 116 Timeline.TimelineUIUtils.buildTraceEventDetails(traceEvent, this.model().tim elineModel(), this._linkifier, false)
117 traceEvent, this.model().timelineModel(), this._linkifier, false, showDe tails.bind(this)); 117 .then(fragment => this._detailsView.element.appendChild(fragment));
118 return true; 118 return true;
119
120 /**
121 * @param {!DocumentFragment} fragment
122 * @this {Timeline.EventsTimelineTreeView}
123 */
124 function showDetails(fragment) {
125 this._detailsView.element.appendChild(fragment);
126 }
127 } 119 }
128 120
129 /** 121 /**
130 * @override 122 * @override
131 * @param {?TimelineModel.TimelineProfileTree.Node} node 123 * @param {?TimelineModel.TimelineProfileTree.Node} node
132 */ 124 */
133 _onHover(node) { 125 _onHover(node) {
134 this._delegate.highlightEvent(node && node.event); 126 this._delegate.highlightEvent(node && node.event);
135 } 127 }
136 }; 128 };
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
206 this.dispatchEventToListeners(Timeline.EventsTimelineTreeView.Filters.Events .FilterChanged); 198 this.dispatchEventToListeners(Timeline.EventsTimelineTreeView.Filters.Events .FilterChanged);
207 } 199 }
208 }; 200 };
209 201
210 Timeline.EventsTimelineTreeView.Filters._durationFilterPresetsMs = [0, 1, 15]; 202 Timeline.EventsTimelineTreeView.Filters._durationFilterPresetsMs = [0, 1, 15];
211 203
212 /** @enum {symbol} */ 204 /** @enum {symbol} */
213 Timeline.EventsTimelineTreeView.Filters.Events = { 205 Timeline.EventsTimelineTreeView.Filters.Events = {
214 FilterChanged: Symbol('FilterChanged') 206 FilterChanged: Symbol('FilterChanged')
215 }; 207 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698