Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Issue 2713323002: Fix underflow duration calculation for MSE. (Closed)

Created:
3 years, 10 months ago by DaleCurtis
Modified:
3 years, 10 months ago
CC:
apacible+watch_chromium.org, chromium-reviews, erickung+watch_chromium.org, feature-media-reviews_chromium.org, miu+watch_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix underflow duration calculation for MSE. http://crrev.com/452113 extended underflow duration tracking for MSE, but did not actually enable the timer :( BUG=641633 TEST=manual Review-Url: https://codereview.chromium.org/2713323002 Cr-Commit-Position: refs/heads/master@{#453001} Committed: https://chromium.googlesource.com/chromium/src/+/d06eabc40101635e329c9e27e5008b123fdd815a

Patch Set 1 #

Patch Set 2 : Fix comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M media/blink/webmediaplayer_impl.cc View 1 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
DaleCurtis
3 years, 10 months ago (2017-02-24 22:08:36 UTC) #3
sandersd (OOO until July 31)
lgtm
3 years, 10 months ago (2017-02-24 22:13:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2713323002/20001
3 years, 10 months ago (2017-02-24 22:20:21 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 23:44:15 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d06eabc40101635e329c9e27e500...

Powered by Google App Engine
This is Rietveld 408576698