Increase test coverage for Navigation.MainFrameSchemeDifferentPage

Increase test coverage for Navigation.MainFrameSchemeDifferentPage

This CL adds tests around this metrics to make sure that it is emitted
correctly during navigation.

TEST = NavigationMetricsRecorderBrowserTest, NavigationMetrics

Review-Url: https://codereview.chromium.org/2713273002
Cr-Commit-Position: refs/heads/master@{#454988}
Committed: https://chromium.googlesource.com/chromium/src/+/2fd0d88d674246f33b92619525c101630dd4f77e

[Amey J, 2017-02-24 19:55:35]

jahagird@amazon.com changed reviewers:
+ avi@chromium.org, sdefresne@chromium.org

[Amey J, 2017-02-24 19:55:36]

Hi,

Could you please take a look at this CL.

- Amey

[Avi (use Gerrit), 2017-02-24 20:14:58]

On 2017/02/24 19:55:36, jahagird wrote:
> Hi,
> 
> Could you please take a look at this CL.
> 
> - Amey

In future CLs, make sure to specify who should be looking at what. I'm assuming
that I'm looking at the tab_contents directory, and that LGTM.

[Amey J, 2017-02-24 21:36:56]

On 2017/02/24 20:14:58, Avi wrote:
> On 2017/02/24 19:55:36, jahagird wrote:
> > Hi,
> > 
> > Could you please take a look at this CL.
> > 
> > - Amey
> 
> In future CLs, make sure to specify who should be looking at what. I'm
assuming
> that I'm looking at the tab_contents directory, and that LGTM.

Sorry for the confusion. I will follow it in the future.

[Amey J, 2017-03-06 18:54:21]

Hi sdefresne@,

Gentle reminder to review /components/ and components/navigation_metrics
changes.

- Amey

[sdefresne, 2017-03-06 19:07:52]

components/* lgtm

[Amey J, 2017-03-06 19:25:20]

The CQ bit was checked by jahagird@amazon.com

[commit-bot: I haz the power, 2017-03-06 19:26:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 20:30:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 20:30:45]

Failed to apply patch for AUTHORS:
While running git apply --index -p1;
  error: patch failed: AUTHORS:45
  error: AUTHORS: patch does not apply

Patch:       AUTHORS
Index: AUTHORS
diff --git a/AUTHORS b/AUTHORS
index
7d172b41fc6bfebef2818478468628e9a59f7f45..b7a620530a595902f24bc57c43dd51e4b7825650
100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -45,6 +45,7 @@ Alfredo Hernandez <ahernandez.miralles@gmail.com>
 Ali Vathi <ali.akbar@gmail.com>
 Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
 Ambarish Rapte <ambarish.r@samsung.com>
+Amey Jahagirdar <jahagird@amazon.com>
 Amit Sarkar <amit.srkr@samsung.com>
 Amogh Bihani <amogh.bihani@samsung.com>
 Amos Lim <amoseui@gmail.com>

[Amey J, 2017-03-06 21:26:28]

The CQ bit was checked by jahagird@amazon.com

[Amey J, 2017-03-06 21:26:29]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2713273002/#ps20001
(title: "Increase test coverage for Navigation.MainFrameSchemeDifferentPage")

[commit-bot: I haz the power, 2017-03-06 21:27:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 22:58:58]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488835588632520,
"parent_rev": "7a77bacfbf5f0e7eb11cb69c8e2c1f3abd0dd87d", "commit_rev":
"2fd0d88d674246f33b92619525c101630dd4f77e"}

[commit-bot: I haz the power, 2017-03-06 23:00:06]

Description was changed from

==========
Increase test coverage for Navigation.MainFrameSchemeDifferentPage

This CL adds tests around this metrics to make sure that it is emitted
correctly during navigation.

TEST = NavigationMetricsRecorderBrowserTest, NavigationMetrics
==========

to

==========
Increase test coverage for Navigation.MainFrameSchemeDifferentPage

This CL adds tests around this metrics to make sure that it is emitted
correctly during navigation.

TEST = NavigationMetricsRecorderBrowserTest, NavigationMetrics

Review-Url: https://codereview.chromium.org/2713273002
Cr-Commit-Position: refs/heads/master@{#454988}
Committed:
https://chromium.googlesource.com/chromium/src/+/2fd0d88d674246f33b92619525c1...
==========

[commit-bot: I haz the power, 2017-03-06 23:00:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2fd0d88d674246f33b92619525c1...