Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2713223002: Use mash::session::mojom::kServiceName instead of a hardcoded string (Closed)

Created:
3 years, 10 months ago by fwang
Modified:
3 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, tonikitoo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use mash::session::mojom::kServiceName instead of a hardcoded string chrome/test/base/mash_browser_tests_main.cc is the only place where the hardcoded string "mash_session" is used. This CL replaces it with the Mojo constant mash::session::mojom::kServiceName. R=sky@chromium.org BUG=None Review-Url: https://codereview.chromium.org/2713223002 Cr-Commit-Position: refs/heads/master@{#452884} Committed: https://chromium.googlesource.com/chromium/src/+/d5bd4ec6e80ced1af3ddcf13c45c851a734400c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/base/mash_browser_tests_main.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
fwang
PTAL
3 years, 10 months ago (2017-02-24 17:01:37 UTC) #1
sky
LGTM
3 years, 10 months ago (2017-02-24 18:38:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2713223002/1
3 years, 10 months ago (2017-02-24 18:42:22 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 18:52:38 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d5bd4ec6e80ced1af3ddcf13c45c...

Powered by Google App Engine
This is Rietveld 408576698