Add AST factories for formal parameters with all optional named parameters.

Add AST factories for formal parameters with all optional named parameters.

Also add 'covariantKeyword' to the Impl constructors and named factories.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/3d88437bda182705d8c0b74483683e716606ac25

[Brian Wilkerson, 2017-02-24 18:27:59]

The downside of this approach is that the parameter name is now part of the API.

That said, lgtm.

https://codereview.chromium.org/2713173003/diff/1/pkg/analyzer/lib/dart/ast/a...
File pkg/analyzer/lib/dart/ast/ast_factory.dart (right):

https://codereview.chromium.org/2713173003/diff/1/pkg/analyzer/lib/dart/ast/a...
pkg/analyzer/lib/dart/ast/ast_factory.dart:963: /**
nit: restore blank line

[scheglov, 2017-02-24 20:09:49]

Description was changed from

==========
Add AST factories for formal parameters with all optional named parameters.

Also add 'covariantKeyword' to the Impl constructors and named factories.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Add AST factories for formal parameters with all optional named parameters.

Also add 'covariantKeyword' to the Impl constructors and named factories.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/3d88437bda182705d8c0b74483683e716606ac25
==========

[scheglov, 2017-02-24 20:09:50]

Committed patchset #1 (id:1) manually as
3d88437bda182705d8c0b74483683e716606ac25 (presubmit successful).

[Paul Berry, 2017-02-24 20:29:04]

lgtm

https://codereview.chromium.org/2713173003/diff/1/pkg/analyzer/lib/dart/ast/a...
File pkg/analyzer/lib/dart/ast/ast_factory.dart (right):

https://codereview.chromium.org/2713173003/diff/1/pkg/analyzer/lib/dart/ast/a...
pkg/analyzer/lib/dart/ast/ast_factory.dart:423: FieldFormalParameter
fieldFormalParameter(
Consider marking as @deprecated and adding a comment instructing clients to
start using fieldFormalParameter2.

Same for the other factory methods in this CL.