Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Unified Diff: pkg/analyzer/lib/src/dart/ast/ast.dart

Issue 2713173003: Add AST factories for formal parameters with all optional named parameters. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/dart/ast/ast.dart
diff --git a/pkg/analyzer/lib/src/dart/ast/ast.dart b/pkg/analyzer/lib/src/dart/ast/ast.dart
index d1c684bc943bf2bb6ec103e1fc139e05f19ef1e9..c4a31773eee8e54116d47f3d043b0f418c344d89 100644
--- a/pkg/analyzer/lib/src/dart/ast/ast.dart
+++ b/pkg/analyzer/lib/src/dart/ast/ast.dart
@@ -4457,6 +4457,7 @@ class FieldFormalParameterImpl extends NormalFormalParameterImpl
FieldFormalParameterImpl(
CommentImpl comment,
List<Annotation> metadata,
+ Token covariantKeyword,
this.keyword,
TypeAnnotationImpl type,
this.thisKeyword,
@@ -4464,7 +4465,7 @@ class FieldFormalParameterImpl extends NormalFormalParameterImpl
SimpleIdentifierImpl identifier,
TypeParameterListImpl typeParameters,
FormalParameterListImpl parameters)
- : super(comment, metadata, identifier) {
+ : super(comment, metadata, covariantKeyword, identifier) {
_type = _becomeParentOf(type);
_typeParameters = _becomeParentOf(typeParameters);
_parameters = _becomeParentOf(parameters);
@@ -5574,12 +5575,13 @@ class FunctionTypedFormalParameterImpl extends NormalFormalParameterImpl
FunctionTypedFormalParameterImpl(
CommentImpl comment,
List<Annotation> metadata,
+ Token covariantKeyword,
TypeAnnotationImpl returnType,
SimpleIdentifierImpl identifier,
TypeParameterListImpl typeParameters,
FormalParameterListImpl parameters,
this.question)
- : super(comment, metadata, identifier) {
+ : super(comment, metadata, covariantKeyword, identifier) {
_returnType = _becomeParentOf(returnType);
_typeParameters = _becomeParentOf(typeParameters);
_parameters = _becomeParentOf(parameters);
@@ -8138,7 +8140,7 @@ abstract class NormalFormalParameterImpl extends FormalParameterImpl
* corresponding attribute.
*/
NormalFormalParameterImpl(CommentImpl comment, List<Annotation> metadata,
- SimpleIdentifierImpl identifier) {
+ this.covariantKeyword, SimpleIdentifierImpl identifier) {
_comment = _becomeParentOf(comment);
_metadata = new NodeListImpl<Annotation>(this, metadata);
_identifier = _becomeParentOf(identifier);
@@ -9237,9 +9239,14 @@ class SimpleFormalParameterImpl extends NormalFormalParameterImpl
* corresponding attribute. The [keyword] can be `null` if a type was
* specified. The [type] must be `null` if the keyword is 'var'.
*/
- SimpleFormalParameterImpl(CommentImpl comment, List<Annotation> metadata,
- this.keyword, TypeAnnotationImpl type, SimpleIdentifierImpl identifier)
- : super(comment, metadata, identifier) {
+ SimpleFormalParameterImpl(
+ CommentImpl comment,
+ List<Annotation> metadata,
+ Token covariantKeyword,
+ this.keyword,
+ TypeAnnotationImpl type,
+ SimpleIdentifierImpl identifier)
+ : super(comment, metadata, covariantKeyword, identifier) {
_type = _becomeParentOf(type);
}

Powered by Google App Engine
This is Rietveld 408576698