[turbofan] Constant-fold concatenation of strings.

[turbofan] Constant-fold concatenation of strings.

For a + b, where both a and b are known strings at compile
time, and the combined length of a and b doesn't overflow
the maximum allowed string length, we can constant-fold the
string concatenation during compilation.

R=yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2713093003
Cr-Commit-Position: refs/heads/master@{#43401}
Committed: https://chromium.googlesource.com/v8/v8/+/27fb7b8348aa125ad225b2c3949b0605c184729c

[Benedikt Meurer, 2017-02-24 05:32:49]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 05:32:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2017-02-24 05:33:37]

Description was changed from

==========
[turbofan] Constant-fold concatenation of (internalized) strings.

For a + b, where both a and b are known (internalized) strings at
compile time, and the combined length of a and b doesn't overflow
the maximum allowed string length, we can constant-fold the string
concatenation during compilation and create an internalized string.

R=yangguo@chromium.org
==========

to

==========
[turbofan] Constant-fold concatenation of strings.

For a + b, where both a and b are known strings at compile
time, and the combined length of a and b doesn't overflow
the maximum allowed string length, we can constant-fold the
string concatenation during compilation and create an
(internalized) string.

R=yangguo@chromium.org
==========

[Yang, 2017-02-24 05:41:06]

On 2017/02/24 05:32:47, Benedikt Meurer wrote:

lgtm

[Benedikt Meurer, 2017-02-24 05:41:14]

The CQ bit was unchecked by bmeurer@chromium.org

[Benedikt Meurer, 2017-02-24 05:41:17]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2017-02-24 05:41:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 05:48:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 05:48:04]

Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[Benedikt Meurer, 2017-02-24 05:56:55]

Description was changed from

==========
[turbofan] Constant-fold concatenation of strings.

For a + b, where both a and b are known strings at compile
time, and the combined length of a and b doesn't overflow
the maximum allowed string length, we can constant-fold the
string concatenation during compilation and create an
(internalized) string.

R=yangguo@chromium.org
==========

to

==========
[turbofan] Constant-fold concatenation of strings.

For a + b, where both a and b are known strings at compile
time, and the combined length of a and b doesn't overflow
the maximum allowed string length, we can constant-fold the
string concatenation during compilation.

R=yangguo@chromium.org
==========

[Benedikt Meurer, 2017-02-24 05:57:07]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2017-02-24 05:57:08]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2713093003/#ps20001
(title: "Don't internalize.")

[commit-bot: I haz the power, 2017-02-24 05:57:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 06:21:11]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487915827857260,
"parent_rev": "59eb62d48303bb15561b1b8f3e8fa1e53b3cc9e6", "commit_rev":
"27fb7b8348aa125ad225b2c3949b0605c184729c"}

[commit-bot: I haz the power, 2017-02-24 06:21:16]

Description was changed from

==========
[turbofan] Constant-fold concatenation of strings.

For a + b, where both a and b are known strings at compile
time, and the combined length of a and b doesn't overflow
the maximum allowed string length, we can constant-fold the
string concatenation during compilation.

R=yangguo@chromium.org
==========

to

==========
[turbofan] Constant-fold concatenation of strings.

For a + b, where both a and b are known strings at compile
time, and the combined length of a and b doesn't overflow
the maximum allowed string length, we can constant-fold the
string concatenation during compilation.

R=yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2713093003
Cr-Commit-Position: refs/heads/master@{#43401}
Committed:
https://chromium.googlesource.com/v8/v8/+/27fb7b8348aa125ad225b2c3949b0605c18...
==========

[commit-bot: I haz the power, 2017-02-24 06:21:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/27fb7b8348aa125ad225b2c3949b0605c18...