Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2713053002: Remove the --no-error-notification flag. (Closed)

Created:
3 years, 10 months ago by devoncarew
Modified:
3 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -94 lines) Patch
M pkg/analysis_server/doc/api.html View 2 chunks +4 lines, -7 lines 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 4 chunks +1 line, -8 lines 0 comments Download
M pkg/analysis_server/lib/src/server/driver.dart View 3 chunks +0 lines, -10 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/error_test.dart View 3 chunks +0 lines, -46 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_test_methods.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_tests.dart View 2 chunks +0 lines, -4 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 2 chunks +4 lines, -7 lines 0 comments Download
M pkg/analyzer_plugin/doc/api.html View 1 chunk +1 line, -5 lines 0 comments Download
M pkg/analyzer_plugin/tool/spec/plugin_spec.html View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
devoncarew
Remove the --no-error-notification flag (fix https://github.com/dart-lang/sdk/issues/28869). No known clients are using this flag.
3 years, 10 months ago (2017-02-23 23:59:41 UTC) #2
Brian Wilkerson
lgtm
3 years, 10 months ago (2017-02-24 00:04:18 UTC) #3
devoncarew
3 years, 10 months ago (2017-02-24 00:55:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0f7fc43df5b56d5a50d7a7bfe1e11c33f846f789 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698