Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1119)

Unified Diff: pkg/analysis_server/test/integration/analysis/error_test.dart

Issue 2713053002: Remove the --no-error-notification flag. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/integration/analysis/error_test.dart
diff --git a/pkg/analysis_server/test/integration/analysis/error_test.dart b/pkg/analysis_server/test/integration/analysis/error_test.dart
index 1b1f69b6805ed7f0226478a08c370e2671085a86..5c4bea4be28d41d396134fcfc0e02cadec086c1a 100644
--- a/pkg/analysis_server/test/integration/analysis/error_test.dart
+++ b/pkg/analysis_server/test/integration/analysis/error_test.dart
@@ -2,8 +2,6 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-import 'dart:async';
-
import 'package:analysis_server/plugin/protocol/protocol.dart';
import 'package:test/test.dart';
import 'package:test_reflective_loader/test_reflective_loader.dart';
@@ -13,8 +11,6 @@ import '../integration_tests.dart';
main() {
defineReflectiveSuite(() {
defineReflectiveTests(AnalysisErrorIntegrationTest);
- defineReflectiveTests(NoAnalysisErrorsIntegrationTest);
- defineReflectiveTests(NoAnalysisErrorsIntegrationTest_Driver);
});
}
@@ -101,45 +97,3 @@ abstract class C extends B {
@reflectiveTest
class AnalysisErrorIntegrationTest
extends AbstractAnalysisErrorIntegrationTest {}
-
-@reflectiveTest
-class NoAnalysisErrorsIntegrationTest
- extends AbstractAnalysisServerIntegrationTest {
- @override
- Future startServer(
- {bool checked: true, int diagnosticPort, int servicesPort}) =>
- server.start(
- checked: checked,
- diagnosticPort: diagnosticPort,
- enableNewAnalysisDriver: enableNewAnalysisDriver,
- noErrorNotification: true,
- servicesPort: servicesPort);
-
- test_detect_simple_error() {
- String pathname = sourcePath('test.dart');
- writeFile(
- pathname,
- '''
-main() {
- print(null) // parse error: missing ';'
-}''');
- standardAnalysisSetup();
- return analysisFinished.then((_) {
- expect(currentAnalysisErrors[pathname], isNull);
- });
- }
-}
-
-@reflectiveTest
-class NoAnalysisErrorsIntegrationTest_Driver
- extends NoAnalysisErrorsIntegrationTest {
- @override
- bool get enableNewAnalysisDriver => true;
-
- @failingTest
- @override
- test_detect_simple_error() {
- // Errors are reported with noErrorNotification: true (#28869).
- return super.test_detect_simple_error();
- }
-}
« no previous file with comments | « pkg/analysis_server/lib/src/server/driver.dart ('k') | pkg/analysis_server/test/integration/integration_test_methods.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698