Layered component for web payments

Layered component for web payments

This patch splits up //components/payments into two layers to
accommodate usage in iOS.

//components/payments/core    - Can be used from iOS.
//components/payments/content - Cannot be used from iOS.

Based on layering instructions:
https://www.chromium.org/developers/design-documents/structure-of-layered-components-within-the-chromium-codebase

BUG=679381
Review-Url: https://codereview.chromium.org/2713033004
Cr-Commit-Position: refs/heads/master@{#453344}
Committed: https://chromium.googlesource.com/chromium/src/+/908248cbb5439c9a2ca5150688d641982857000a

[please use gerrit instead, 2017-02-24 20:59:46]

Description was changed from

==========
Layered component for payments

This patch splits up //components/payments into two layers to
accommodate usage in iOS.

//components/payments/core    - Can be used from iOS.
//components/payments/content - Cannot be used from iOS.

BUG=79381
==========

to

==========
Layered component for web payments

This patch splits up //components/payments into two layers to
accommodate usage in iOS.

//components/payments/core    - Can be used from iOS.
//components/payments/content - Cannot be used from iOS.

BUG=79381
==========

[please use gerrit instead, 2017-02-24 21:10:44]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[please use gerrit instead, 2017-02-24 21:11:49]

Description was changed from

==========
Layered component for web payments

This patch splits up //components/payments into two layers to
accommodate usage in iOS.

//components/payments/core    - Can be used from iOS.
//components/payments/content - Cannot be used from iOS.

BUG=79381
==========

to

==========
Layered component for web payments

This patch splits up //components/payments into two layers to
accommodate usage in iOS.

//components/payments/core    - Can be used from iOS.
//components/payments/content - Cannot be used from iOS.

Based on layering instructions:
https://www.chromium.org/developers/design-documents/structure-of-layered-com...

BUG=79381
==========

[commit-bot: I haz the power, 2017-02-24 21:12:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2017-02-24 21:13:31]

rouslan@chromium.org changed reviewers:
+ mathp@chromium.org

[please use gerrit instead, 2017-02-24 21:13:32]

Mathieu, ptal this tiny tweak.

[Mathieu, 2017-02-24 21:31:30]

lgtm for the parts I can approve. Thanks for fixing up along the way. 

We should plan to have some validation in core/ (splitting it off from Mojo
somehow), because otherwise our poor iOS developer will have to reimplement a
lot of it.

[please use gerrit instead, 2017-02-24 21:33:43]

Description was changed from

==========
Layered component for web payments

This patch splits up //components/payments into two layers to
accommodate usage in iOS.

//components/payments/core    - Can be used from iOS.
//components/payments/content - Cannot be used from iOS.

Based on layering instructions:
https://www.chromium.org/developers/design-documents/structure-of-layered-com...

BUG=79381
==========

to

==========
Layered component for web payments

This patch splits up //components/payments into two layers to
accommodate usage in iOS.

//components/payments/core    - Can be used from iOS.
//components/payments/content - Cannot be used from iOS.

Based on layering instructions:
https://www.chromium.org/developers/design-documents/structure-of-layered-com...

BUG=679381
==========

[please use gerrit instead, 2017-02-24 21:35:27]

rouslan@chromium.org changed reviewers:
+ brettw@chromium.org

[please use gerrit instead, 2017-02-24 21:35:28]

Brett, owners ptal.

[please use gerrit instead, 2017-02-24 21:36:41]

rouslan@chromium.org changed reviewers:
+ tsepez@chromium.org

[please use gerrit instead, 2017-02-24 21:36:42]

Tom, security owners ptal mojom and type_converters.

[brettw, 2017-02-24 22:10:03]

owners rs lgtm

[commit-bot: I haz the power, 2017-02-24 22:55:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 22:55:55]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2017-02-24 23:06:16]

RS LGTM

[haraken, 2017-02-25 00:36:25]

WebKit LGTM

[please use gerrit instead, 2017-02-25 00:39:47]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2017-02-25 00:39:50]

The CQ bit was unchecked by rouslan@chromium.org

[please use gerrit instead, 2017-02-27 15:30:12]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2017-02-27 15:30:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2017-02-27 15:42:28]

The CQ bit was unchecked by rouslan@chromium.org

[please use gerrit instead, 2017-02-27 15:43:15]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2017-02-27 15:43:16]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org,
tsepez@chromium.org, haraken@chromium.org, brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2713033004/#ps20001
(title: "Rebase on top of http://crrev.com/2717933004")

[commit-bot: I haz the power, 2017-02-27 15:43:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 17:23:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 17:23:35]

Failed to apply patch for
chrome/browser/ui/views/payments/payment_request_credit_card_editor_interactive_uitest.cc:
While running git apply --index -p1;
  error: patch failed:
chrome/browser/ui/views/payments/payment_request_credit_card_editor_interactive_uitest.cc:14
  error:
chrome/browser/ui/views/payments/payment_request_credit_card_editor_interactive_uitest.cc:
patch does not apply

Patch:      
chrome/browser/ui/views/payments/payment_request_credit_card_editor_interactive_uitest.cc
Index:
chrome/browser/ui/views/payments/payment_request_credit_card_editor_interactive_uitest.cc
diff --git
a/chrome/browser/ui/views/payments/payment_request_credit_card_editor_interactive_uitest.cc
b/chrome/browser/ui/views/payments/payment_request_credit_card_editor_interactive_uitest.cc
index
e408da89f596c9b99461eb5bee005ca61fc25579..bc8fb2103f006ad7b4d220978f44ebfbabc5c6e4
100644
---
a/chrome/browser/ui/views/payments/payment_request_credit_card_editor_interactive_uitest.cc
+++
b/chrome/browser/ui/views/payments/payment_request_credit_card_editor_interactive_uitest.cc
@@ -14,7 +14,7 @@
 #include "components/autofill/core/browser/personal_data_manager.h"
 #include "components/autofill/core/browser/personal_data_manager_observer.h"
 #include "components/autofill/core/browser/test_autofill_clock.h"
-#include "components/payments/payment_request.h"
+#include "components/payments/content/payment_request.h"
 #include "components/strings/grit/components_strings.h"
 #include "content/public/test/browser_test_utils.h"
 #include "testing/gmock/include/gmock/gmock.h"

[please use gerrit instead, 2017-02-27 17:35:02]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2017-02-27 17:35:03]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org,
tsepez@chromium.org, haraken@chromium.org, brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2713033004/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-02-27 17:35:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 17:57:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 17:57:03]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[please use gerrit instead, 2017-02-27 18:47:42]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2017-02-27 18:47:43]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org,
tsepez@chromium.org, haraken@chromium.org, brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2713033004/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-02-27 18:48:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 21:30:30]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488221262368590,
"parent_rev": "cad99ab06ac789823d4e8df241a05098df1dd124", "commit_rev":
"908248cbb5439c9a2ca5150688d641982857000a"}

[commit-bot: I haz the power, 2017-02-27 21:31:07]

Description was changed from

==========
Layered component for web payments

This patch splits up //components/payments into two layers to
accommodate usage in iOS.

//components/payments/core    - Can be used from iOS.
//components/payments/content - Cannot be used from iOS.

Based on layering instructions:
https://www.chromium.org/developers/design-documents/structure-of-layered-com...

BUG=679381
==========

to

==========
Layered component for web payments

This patch splits up //components/payments into two layers to
accommodate usage in iOS.

//components/payments/core    - Can be used from iOS.
//components/payments/content - Cannot be used from iOS.

Based on layering instructions:
https://www.chromium.org/developers/design-documents/structure-of-layered-com...

BUG=679381

Review-Url: https://codereview.chromium.org/2713033004
Cr-Commit-Position: refs/heads/master@{#453344}
Committed:
https://chromium.googlesource.com/chromium/src/+/908248cbb5439c9a2ca5150688d6...
==========

[commit-bot: I haz the power, 2017-02-27 21:31:10]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/908248cbb5439c9a2ca5150688d6...