Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2713023005: Fix some nits from r447440. (Closed)

Created:
3 years, 10 months ago by Lei Zhang
Modified:
3 years, 8 months ago
Reviewers:
rbpotter
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix some nits from r447440. Review-Url: https://codereview.chromium.org/2713023005 Cr-Commit-Position: refs/heads/master@{#460922} Committed: https://chromium.googlesource.com/chromium/src/+/c8800cb24b064284f934755bd6da9301b8b8330f

Patch Set 1 #

Patch Set 2 : rebase, git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -20 lines) Patch
M chrome/browser/printing/print_job.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/pwg_raster_converter.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/pwg_raster_converter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_features.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/service/cloud_print/print_system_win.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/utility/printing_handler.cc View 1 chunk +12 lines, -7 lines 0 comments Download
M printing/pdf_render_settings.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M printing/print_settings.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
Lei Zhang
3 years, 8 months ago (2017-03-29 21:53:16 UTC) #8
rbpotter
On 2017/03/29 21:53:16, Lei Zhang wrote: lgtm
3 years, 8 months ago (2017-03-30 19:40:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2713023005/20001
3 years, 8 months ago (2017-03-30 20:27:08 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 23:21:09 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c8800cb24b064284f934755bd6da...

Powered by Google App Engine
This is Rietveld 408576698