Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1015)

Unified Diff: chrome/browser/android/offline_pages/offline_page_utils_unittest.cc

Issue 2713013002: Track original URL when downloading a redirected page (Closed)
Patch Set: A little update Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/offline_page_utils_unittest.cc
diff --git a/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc b/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc
index 2be4550e402d9af775a3f030b7dfbe901f1e1e94..8f55101fdd8e6e87c10824208ee3c7e6061a3278 100644
--- a/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc
+++ b/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc
@@ -186,12 +186,11 @@ void OfflinePageUtilsTest::CreateRequests() {
RequestCoordinator* request_coordinator =
RequestCoordinatorFactory::GetForBrowserContext(profile());
- offline_pages::ClientId client_id;
- client_id.name_space = kDownloadNamespace;
- client_id.id = kTestPage3ClientId;
- request_coordinator->SavePageLater(
- kTestPage3Url, client_id, true,
- RequestCoordinator::RequestAvailability::ENABLED_FOR_OFFLINER);
+ RequestCoordinator::SavePageLaterParams params;
+ params.url = kTestPage3Url;
+ params.client_id =
+ offline_pages::ClientId(kDownloadNamespace, kTestPage3ClientId);
fgorski 2017/02/27 17:34:36 are you missing availability here?
jianli 2017/02/27 23:20:06 ditto.
+ request_coordinator->SavePageLater(params);
RunUntilIdle();
}

Powered by Google App Engine
This is Rietveld 408576698