Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: chrome/browser/net/net_error_tab_helper.cc

Issue 2713013002: Track original URL when downloading a redirected page (Closed)
Patch Set: A little update Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/net_error_tab_helper.cc
diff --git a/chrome/browser/net/net_error_tab_helper.cc b/chrome/browser/net/net_error_tab_helper.cc
index 2cac81cd148ec5ff5d0b390d9df393c532cb4515..7453d790d2be7152821643239fb76d53fafa195b 100644
--- a/chrome/browser/net/net_error_tab_helper.cc
+++ b/chrome/browser/net/net_error_tab_helper.cc
@@ -296,12 +296,11 @@ void NetErrorTabHelper::DownloadPageLaterHelper(const GURL& page_url) {
offline_pages::RequestCoordinatorFactory::GetForBrowserContext(
web_contents()->GetBrowserContext());
DCHECK(request_coordinator) << "No RequestCoordinator for SavePageLater";
- offline_pages::ClientId client_id(
- offline_pages::kAsyncNamespace, base::GenerateGUID());
- request_coordinator->SavePageLater(
- page_url, client_id, true /*user_requested*/,
- offline_pages::RequestCoordinator::RequestAvailability::
- ENABLED_FOR_OFFLINER);
+ offline_pages::RequestCoordinator::SavePageLaterParams params;
+ params.url = page_url;
+ params.client_id = offline_pages::ClientId(offline_pages::kAsyncNamespace,
+ base::GenerateGUID());
fgorski 2017/02/27 17:34:36 are you missing availability and user_requested?
jianli 2017/02/27 23:20:06 ditto.
+ request_coordinator->SavePageLater(params);
}
#endif // defined(OS_ANDROID)

Powered by Google App Engine
This is Rietveld 408576698