Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Unified Diff: media/base/media_client.h

Issue 2712983004: Simplify/Cleanup MediaClient (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/media_client.h
diff --git a/media/base/media_client.h b/media/base/media_client.h
index e5beb94ef94d2d5c747e5749fe12c690f7adcbae..f6b938b0dc02dcb0e27db80b87595c2b4f76374f 100644
--- a/media/base/media_client.h
+++ b/media/base/media_client.h
@@ -5,6 +5,7 @@
#ifndef MEDIA_BASE_MEDIA_CLIENT_H_
#define MEDIA_BASE_MEDIA_CLIENT_H_
+#include <memory>
#include <string>
#include <vector>
@@ -30,20 +31,6 @@ MEDIA_EXPORT void SetMediaClient(MediaClient* media_client);
MEDIA_EXPORT MediaClient* GetMediaClient();
#endif
-struct MEDIA_EXPORT KeySystemInfoForUMA {
- KeySystemInfoForUMA(const std::string& key_system,
- const std::string& key_system_name_for_uma);
- ~KeySystemInfoForUMA();
-
- // Concrete key system name;
- std::string key_system;
-
- // Display name for UMA reporting. For example, the display name for
- // "org.w3.clearkey" is "ClearKey". When providing this value, make sure to
- // update tools/metrics/histograms/histograms.xml.
- std::string key_system_name_for_uma;
-};
-
// A client interface for embedders (e.g. content/renderer) to provide
// customized service.
class MEDIA_EXPORT MediaClient {
@@ -51,15 +38,6 @@ class MEDIA_EXPORT MediaClient {
MediaClient();
virtual ~MediaClient();
- // Provides UMA info for key systems that SHOULD be reported to UMA, no matter
- // whether a key system is actually supported by this client or not. Only
- // called once per instance.
- virtual void AddKeySystemsInfoForUMA(
- std::vector<KeySystemInfoForUMA>* key_systems_info_for_uma) = 0;
-
- // Returns whether client key systems properties should be updated.
- virtual bool IsKeySystemsUpdateNeeded() = 0;
-
// Adds properties for supported key systems.
virtual void AddSupportedKeySystems(
std::vector<std::unique_ptr<KeySystemProperties>>*

Powered by Google App Engine
This is Rietveld 408576698