[interpreter] Teach --print-bytecode the names of runtime functions and intrinsics.

[interpreter] Teach --print-bytecode the names of runtime functions and intrinsics.

This changes the bytecode decoder such that --print-bytecode will print

    ... CallRuntime [GeneratorGetResumeMode] ...
    ... InvokeIntrinsic [CreateIterResultObject] ...

instead of

    ... CallRuntime [762] ...
    ... InvokeIntrinsic [2] ...

The printing of CallJSRuntime remains unchanged.

R=gsathya@chromium.org, rmcilroy@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2712943002
Cr-Commit-Position: refs/heads/master@{#43391}
Committed: https://chromium.googlesource.com/v8/v8/+/c0651535d5a67dac1587fb1794bbf4cf5516164e

[neis, 2017-02-23 12:54:25]

ptal

[rmcilroy, 2017-02-23 13:47:14]

Awesome, thanks! One suggestion but otherwise LGTM.

https://codereview.chromium.org/2712943002/diff/20001/src/interpreter/bytecod...
File src/interpreter/bytecode-decoder.cc (right):

https://codereview.chromium.org/2712943002/diff/20001/src/interpreter/bytecod...
src/interpreter/bytecode-decoder.cc:150: os << "[" <<
NameForIntrinsicId(DecodeUnsignedOperand(
nit - could you just do NameForRuntimeId(IntrinsicHelper::ToRuntimeId(...)) and
avoid the need for the additional NameForIntrinsicId function?

[neis, 2017-02-23 14:02:31]

Description was changed from

==========
[interpreter] Teach --print-bytecode names of runtime functions and intrinsics.

This changes the bytecode decoder such that --print-bytecode will print

    ... CallRuntime [GeneratorGetResumeMode] ...
    ... InvokeIntrinsic [CreateIterResultObject] ...

instead of

    ... CallRuntime [762] ...
    ... InvokeIntrinsic [2] ...

The printing of CallJSRuntime remains unchanged.

R=gsathya@chromium.org, rmcilroy@chromium.org
BUG=
==========

to

==========
[interpreter] Teach --print-bytecode the names of runtime functions and
intrinsics.

This changes the bytecode decoder such that --print-bytecode will print

    ... CallRuntime [GeneratorGetResumeMode] ...
    ... InvokeIntrinsic [CreateIterResultObject] ...

instead of

    ... CallRuntime [762] ...
    ... InvokeIntrinsic [2] ...

The printing of CallJSRuntime remains unchanged.

R=gsathya@chromium.org, rmcilroy@chromium.org
BUG=
==========

[neis, 2017-02-23 14:02:55]

https://codereview.chromium.org/2712943002/diff/20001/src/interpreter/bytecod...
File src/interpreter/bytecode-decoder.cc (right):

https://codereview.chromium.org/2712943002/diff/20001/src/interpreter/bytecod...
src/interpreter/bytecode-decoder.cc:150: os << "[" <<
NameForIntrinsicId(DecodeUnsignedOperand(
On 2017/02/23 13:47:13, rmcilroy wrote:
> nit - could you just do NameForRuntimeId(IntrinsicHelper::ToRuntimeId(...))
and
> avoid the need for the additional NameForIntrinsicId function?

Done.

[neis, 2017-02-23 14:03:00]

The CQ bit was checked by neis@chromium.org

[neis, 2017-02-23 14:03:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/2712943002/#ps40001
(title: "Make use of ToRuntimeId.")

[commit-bot: I haz the power, 2017-02-23 14:03:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 14:25:46]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487858580435880,
"parent_rev": "68960eeb763f93dcedb37d5b663b1019192b7f36", "commit_rev":
"c0651535d5a67dac1587fb1794bbf4cf5516164e"}

[commit-bot: I haz the power, 2017-02-23 14:25:50]

Description was changed from

==========
[interpreter] Teach --print-bytecode the names of runtime functions and
intrinsics.

This changes the bytecode decoder such that --print-bytecode will print

    ... CallRuntime [GeneratorGetResumeMode] ...
    ... InvokeIntrinsic [CreateIterResultObject] ...

instead of

    ... CallRuntime [762] ...
    ... InvokeIntrinsic [2] ...

The printing of CallJSRuntime remains unchanged.

R=gsathya@chromium.org, rmcilroy@chromium.org
BUG=
==========

to

==========
[interpreter] Teach --print-bytecode the names of runtime functions and
intrinsics.

This changes the bytecode decoder such that --print-bytecode will print

    ... CallRuntime [GeneratorGetResumeMode] ...
    ... InvokeIntrinsic [CreateIterResultObject] ...

instead of

    ... CallRuntime [762] ...
    ... InvokeIntrinsic [2] ...

The printing of CallJSRuntime remains unchanged.

R=gsathya@chromium.org, rmcilroy@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2712943002
Cr-Commit-Position: refs/heads/master@{#43391}
Committed:
https://chromium.googlesource.com/v8/v8/+/c0651535d5a67dac1587fb1794bbf4cf551...
==========

[commit-bot: I haz the power, 2017-02-23 14:25:51]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/c0651535d5a67dac1587fb1794bbf4cf551...