Mark MediaStreamTrackMetrics DISALLOW_COPY_AND_ASSIGN

Mark MediaStreamTrackMetrics DISALLOW_COPY_AND_ASSIGN

After https://codereview.chromium.org/2705073003,
the Windows release component build would fail due to
the compiler trying to instantiate the assignment operator
and copy constructor due to the class being dllexport, and fail
because it now uses unique_ptr.

BUG=695584
TBR=avi

Review-Url: https://codereview.chromium.org/2712913003
Cr-Commit-Position: refs/heads/master@{#452646}
Committed: https://chromium.googlesource.com/chromium/src/+/f087f34d91e04c8890502ac10dfb371da1a0f20c

[hans, 2017-02-23 20:59:44]

The CQ bit was checked by hans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 21:00:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hans, 2017-02-23 21:00:21]

hans@chromium.org changed reviewers:
+ leon.han@intel.com, thakis@chromium.org

[hans, 2017-02-23 21:00:21]

Please take a look.

[Nico, 2017-02-23 21:01:33]

lgtm, thanks!

[hans, 2017-02-23 21:02:20]

The CQ bit was unchecked by hans@chromium.org

[hans, 2017-02-23 21:02:25]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2017-02-23 21:03:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 21:11:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 21:11:18]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nico, 2017-02-23 21:14:54]

Description was changed from

==========
Mark MediaStreamTrackMetrics DISALLOW_COPY_AND_ASSIGN

After https://codereview.chromium.org/2705073003,
the Windows release component build would fail due to
the compiler trying to instantiate the assignment operator
and copy constructur due to the class being dllexport, and fail
because it now uses unique_ptr.

BUG=695584
==========

to

==========
Mark MediaStreamTrackMetrics DISALLOW_COPY_AND_ASSIGN

After https://codereview.chromium.org/2705073003,
the Windows release component build would fail due to
the compiler trying to instantiate the assignment operator
and copy constructur due to the class being dllexport, and fail
because it now uses unique_ptr.

BUG=695584
TBR=avi
==========

[Nico, 2017-02-23 21:15:05]

Description was changed from

==========
Mark MediaStreamTrackMetrics DISALLOW_COPY_AND_ASSIGN

After https://codereview.chromium.org/2705073003,
the Windows release component build would fail due to
the compiler trying to instantiate the assignment operator
and copy constructur due to the class being dllexport, and fail
because it now uses unique_ptr.

BUG=695584
TBR=avi
==========

to

==========
Mark MediaStreamTrackMetrics DISALLOW_COPY_AND_ASSIGN

After https://codereview.chromium.org/2705073003,
the Windows release component build would fail due to
the compiler trying to instantiate the assignment operator
and copy constructor due to the class being dllexport, and fail
because it now uses unique_ptr.

BUG=695584
TBR=avi
==========

[Nico, 2017-02-23 21:15:08]

The CQ bit was checked by thakis@chromium.org

[Nico, 2017-02-23 21:15:28]

thakis@chromium.org changed reviewers:
+ avi@chromium.org

[Nico, 2017-02-23 21:15:29]

tbr=avi for contents/owners

[commit-bot: I haz the power, 2017-02-23 21:15:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2017-02-23 21:19:21]

Yes, the VS C++ libraries are like that.

LGTM

[commit-bot: I haz the power, 2017-02-23 21:59:31]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487884508538600, "parent_rev":
"52b947642a5a9fd60c5fbf61419cca26b1fd72ec", "commit_rev":
"f087f34d91e04c8890502ac10dfb371da1a0f20c"}

[commit-bot: I haz the power, 2017-02-23 22:00:05]

Description was changed from

==========
Mark MediaStreamTrackMetrics DISALLOW_COPY_AND_ASSIGN

After https://codereview.chromium.org/2705073003,
the Windows release component build would fail due to
the compiler trying to instantiate the assignment operator
and copy constructor due to the class being dllexport, and fail
because it now uses unique_ptr.

BUG=695584
TBR=avi
==========

to

==========
Mark MediaStreamTrackMetrics DISALLOW_COPY_AND_ASSIGN

After https://codereview.chromium.org/2705073003,
the Windows release component build would fail due to
the compiler trying to instantiate the assignment operator
and copy constructor due to the class being dllexport, and fail
because it now uses unique_ptr.

BUG=695584
TBR=avi

Review-Url: https://codereview.chromium.org/2712913003
Cr-Commit-Position: refs/heads/master@{#452646}
Committed:
https://chromium.googlesource.com/chromium/src/+/f087f34d91e04c8890502ac10dfb...
==========

[commit-bot: I haz the power, 2017-02-23 22:00:06]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f087f34d91e04c8890502ac10dfb...

[leonhsl(Using Gerrit), 2017-02-24 02:22:56]

Thank you! I'll pay attention to check such cases in future, even if codereview
trybots are green.